Service introspection - #92
Merged
Merged
Conversation
14 tasks
jacobperron
force-pushed
the
service_introspection
branch
from
September 29, 2022 18:37
e2f1e57 to
2784b81
Compare
Member
|
rebased on rolling |
ivanpauno
reviewed
Nov 11, 2022
ivanpauno
left a comment
ivanpauno
left a comment
Member
There was a problem hiding this comment.
I need to check the rosidl_typesupport_fastrtps_c implementation, otherwise I think this is fine
wjwwood
approved these changes
Dec 21, 2022
Signed-off-by: Brian Chen <brian.chen@openrobotics.org>
Signed-off-by: Brian Chen <brian.chen@openrobotics.org>
Signed-off-by: Brian Chen <brian.chen@openrobotics.org>
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
clalancette
force-pushed
the
service_introspection
branch
from
January 25, 2023 18:29
25c762b to
e1eb8c5
Compare
mjcarroll
approved these changes
Jan 31, 2023
Contributor
|
CI for this is in ros2/ros2#1285 (comment) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is part of a prototype implementation for ros-infrastructure/rep#360 ros2/ros2#1285. It implements the new methods defined in
rosidl_runtime_cppin ros2/rosidl#700 allowing for rcl to populate service_event message payloads.