Skip to content

removed deprecated API - #2427

Open
ahcorde wants to merge 1 commit into
rollingfrom
ahcorde/rolling/removed_deprecated_api
Open

removed deprecated API#2427
ahcorde wants to merge 1 commit into
rollingfrom
ahcorde/rolling/removed_deprecated_api

Conversation

@ahcorde

@ahcorde ahcorde commented May 11, 2026

Copy link
Copy Markdown
Contributor

removed deprecated API

Did you use Generative AI?

claude sonnet 4.6

@ahcorde
removed deprecated API
568cdb4 
Signed-off-by: Alejandro Hernandez Cordero <ahcorde@gmail.com>
@ahcorde
ahcorde requested a review from MichaelOrlov May 11, 2026 15:19
@ahcorde ahcorde self-assigned this May 11, 2026
fujitatomoya
fujitatomoya reviewed May 12, 2026
View reviewed changes

@fujitatomoya fujitatomoya left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ahcorde it looks like include the unrelated changes aside from deprecated APIs? e.g removing throwing the exception? besides that, i think we need to rebuild pyi and commit it because that failed in the workflow.

@MichaelOrlov

MichaelOrlov commented May 12, 2026

Copy link
Copy Markdown
Contributor

@ahcorde We talked about this PR on the last PMC meeting and decided to postpone merging this PR for 3 weeks or so, basically to let the dust from the Lyrical release settle down a bit.

@ahcorde

ahcorde commented Jun 5, 2026

Copy link
Copy Markdown
Contributor Author

Pulls: #2427
Gist: https://gist.githubusercontent.com/ahcorde/8ce80bb1e69868c6f2e0ef3d410e9b2d/raw/b364143d09da1eefbecca3751d9a17a914c1bb7d/ros2.repos
BUILD args: --packages-above-and-dependencies rosbag2_cpp rosbag2_py rosbag2_storage rosbag2_storage_mcap rosbag2_storage_sqlite3 rosbag2_tests rosbag2_transport
TEST args: --packages-above rosbag2_cpp rosbag2_py rosbag2_storage rosbag2_storage_mcap rosbag2_storage_sqlite3 rosbag2_tests rosbag2_transport
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/19490

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fujitatomoya fujitatomoya fujitatomoya left review comments
@MichaelOrlov MichaelOrlov Awaiting requested review from MichaelOrlov

At least 1 approving review is required to merge this pull request.

Assignees

@ahcorde ahcorde

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ahcorde @MichaelOrlov @fujitatomoya