Skip to content
1 change: 1 addition & 0 deletions type_description_interfaces/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ rosidl_generate_interfaces(${PROJECT_NAME}
"msg/FieldType.msg"
"msg/IndividualTypeDescription.msg"
"msg/TypeDescription.msg"
"srv/GetTypeDescription.srv"
ADD_LINTER_TESTS
)

Expand Down
2 changes: 2 additions & 0 deletions type_description_interfaces/package.xml
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,8 @@

<buildtool_depend>rosidl_core_generators</buildtool_depend>

<depend>service_msgs</depend>

<exec_depend>rosidl_core_runtime</exec_depend>

Comment thread
emersonknapp marked this conversation as resolved.
<test_depend>ament_lint_auto</test_depend>
Expand Down
27 changes: 27 additions & 0 deletions type_description_interfaces/srv/GetTypeDescription.srv
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
# ROS interface type name, in PACKAGE/NAMESPACE/TYPENAME format
string type_name

# REP-2011 RIHS hash string, which looks like RIHSxx_hashvalue
string type_version_hash
---
# True if the type description information is available and populated in the response
Comment thread
emersonknapp marked this conversation as resolved.
Outdated
bool successful
# Empty if 'successful' was true, otherwise contains details on why it failed
Comment thread
emersonknapp marked this conversation as resolved.
Outdated
string failure_reason

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rename this to reason instead of failure_reason.

@achim-k achim-k Mar 23, 2023

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think something went wrong here, this became failure_reason again (1db9478)

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that might have been intentional since it's no longer multi purpose? I'm not sure I haven't re-reviewed this yet.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct, changed back on purpose, see #153 (comment)


# The idl or msg file name
string type_description_raw_file_name

# The idl or msg file, with comments and whitespace
# The file extension and/or the contents can be used to determine the format
# This contains all recursive raw files, each separated by a line of 80 '=' characters
# The order will be the same as the TypeDescription -
# which is top level interface then referenced type descriptions in alphabetical order by type_name
string type_description_raw
Comment thread
emersonknapp marked this conversation as resolved.
Outdated

# The parsed type description which can be used programmatically
TypeDescription type_description

# Key-value pairs of extra information.
string[] extra_information_keys
string[] extra_information_values
Comment thread
emersonknapp marked this conversation as resolved.
Outdated