fix(infra): add setup-knuckle-upstream workflow and document GH_TOKEN requirement (closes #104)#206
Open
clubanderson wants to merge 1 commit into
Conversation
… requirement (closes projectbluefin#104) Add a WorkflowTemplate that runs on ghost to add the missing `upstream` remote to ~/src/knuckle, fixing `qa-test-pr.sh` failures. Document the GH_TOKEN requirement for gh CLI auth in the agent cheatsheet, runbook, and failure triage tables. Signed-off-by: unknown <unknown@users.noreply.github.com>
hanthor
approved these changes
Jun 6, 2026
hanthor
left a comment
hanthor
left a comment
Member
There was a problem hiding this comment.
LGTM — well-structured test/infra addition, clean code.
hanthor
approved these changes
Jun 16, 2026
hanthor
left a comment
hanthor
left a comment
Member
There was a problem hiding this comment.
Approved via org-wide review.
hanthor
approved these changes
Jun 16, 2026
hanthor
left a comment
hanthor
left a comment
Member
There was a problem hiding this comment.
Approved via org-wide review.
Collaborator
|
This PR has merge conflicts with current main and needs a rebase before it can land. |
hanthor
approved these changes
Jul 1, 2026
hanthor
left a comment
hanthor
left a comment
Member
There was a problem hiding this comment.
Review: Approved ✅
Part of the structured service-catalog project build-up. Conventional Commits format, referenced issues, consistent with related PRs in the series.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes both infrastructure gaps from #104 that cause
qa-test-pr.shto fail on ghost:1. Missing
upstreamremote — WorkflowTemplate fixargo/workflow-templates/setup-knuckle-upstream.yaml— one-shot WorkflowTemplate pinned to ghost that adds theupstreamremote (projectbluefin/knuckle) to~/src/knuckle. Follows the same pattern assetup-ghost-ssh-banner(privileged pod, host volume mount, idempotent). Safe to re-run.Justfile—setup-knuckle-upstreamtarget for operator convenience.2.
ghCLI unauthenticated — documentation fixSince persistent token setup on ghost is a manual/security decision, this PR documents the
GH_TOKENrequirement:RUNBOOK.md— two new failure-mode rows for theqa-test-pr.sherrorsWORKFLOWS.md—setup-knuckle-upstreamtemplate documenteddocs/agent-cheatsheet.md— command selector row + failure triage rowsAfter merge
Run once to apply the fix:
Test plan
just lintpasses (template is well-formed)just setup-knuckle-upstreamruns successfully on ghostssh jorge@192.168.1.102 "cd ~/src/knuckle && git remote get-url upstream"returns the projectbluefin URLqa-test-pr.shno longer fails with theupstreamremote error