Skip to content

Stabilize ActionMenu dialog VRT #8346

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
llastflowers wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Stabilize ActionMenu dialog VRT #8346

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
34515e8
test(vrt): stabilize ActionMenu dialog snapshot
llastflowers Aug 28, 2026
045a0d6
test(vrt): update snapshots
llastflowers Aug 28, 2026
6c92aa0
test(vrt): hide unstable ActionMenu label
llastflowers Aug 28, 2026
adb4d3d
test(vrt): update snapshots
llastflowers Aug 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion e2e/components/ActionMenu.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,12 @@
await page.getByRole('button', {name: buttonName}).click()
}
}
await expect(page).toHaveScreenshot(`ActionMenu.${story.title}.${theme}${suffix}.png`)
await expect(page).toHaveScreenshot(`ActionMenu.${story.title}.${theme}${suffix}.png`, {
style:

Check failure on line 102 in e2e/components/ActionMenu.test.ts

View workflow job for this annotation

GitHub Actions / type-check (react-18) 

Object literal may only specify known properties, and 'style' does not exist in type 'PageAssertionsToHaveScreenshotOptions'.

Check failure on line 102 in e2e/components/ActionMenu.test.ts

View workflow job for this annotation

GitHub Actions / type-check (react-19) 

Object literal may only specify known properties, and 'style' does not exist in type 'PageAssertionsToHaveScreenshotOptions'.
story.title === 'Dev: Within Dialog'
? '[data-component="ActionMenu.Button"] [data-component="text"] { visibility: hidden !important; }'
: undefined,
})
})
}
})
Expand Down
Loading