Skip to content

Stabilize ActionMenu dialog VRT - #8346

Open
llastflowers wants to merge 4 commits into
mainfrom
llastflowers/stabilize-action-menu-dialog-vrt
Open

Stabilize ActionMenu dialog VRT#8346
llastflowers wants to merge 4 commits into
mainfrom
llastflowers/stabilize-action-menu-dialog-vrt

Conversation

@llastflowers

@llastflowers llastflowers commented Aug 28, 2026

Copy link
Copy Markdown
Contributor

Changelog

Changed

  • Hide the dynamically mounted ActionMenu button label when capturing the Within Dialog VRT, avoiding a one-pixel Chromium text-positioning flake while preserving comparisons for the button, dialog, and menu.
  • The Button text positioning will still be covered in other tests by Button snapshots, and other components that contain Buttons

Removed

None.

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; test-only change.

Testing & Reviewing

  • Ran all 18 Dev: Within Dialog ActionMenu VRT variants locally.

Copilot AI lite review requested due to automatic review settings August 28, 2026 19:17
@llastflowers
llastflowers requested a review from a team as a code owner August 28, 2026 19:17
@llastflowers
llastflowers requested a review from joshblack August 28, 2026 19:17
@changeset-bot

changeset-bot Bot commented Aug 28, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: adb4d3d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@llastflowers llastflowers added update snapshots 🤖 Command that updates VRT snapshots on the pull request skip changeset This change does not need a changelog labels Aug 28, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

Review tier: Lite
Findings: None

What changed in this PR

This PR stabilizes the ActionMenu “Within Dialog” visual regression test by injecting a targeted CSS override during screenshot capture to hide a flaky, dynamically mounted button label, while keeping the rest of the UI (button/container/menu) comparable.

Changes:

  • Adds a toHaveScreenshot style override for the Dev: Within Dialog VRT variant to hide [data-component="text"] inside ActionMenu.Button.
  • Keeps all other ActionMenu VRT variants unchanged by leaving the style option unset for non-matching stories.
File Description
e2e/​components/​ActionMenu.test.ts Injects story-specific screenshot CSS to avoid a one-pixel text-positioning flake in the “Within Dialog” VRT.

💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.

@github-actions github-actions Bot removed the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Aug 28, 2026
@github-actions
github-actions Bot temporarily deployed to storybook-preview-8346 August 28, 2026 19:39 Inactive
@joshblack

Copy link
Copy Markdown
Member

@llastflowers I have this one as well: #8332 hopefully these together will address some of the flakiness with VRT 😓

@joshblack joshblack left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hope this works 🤞

@llastflowers llastflowers added the update snapshots 🤖 Command that updates VRT snapshots on the pull request label Aug 28, 2026
@github-actions
github-actions Bot temporarily deployed to storybook-preview-8346 August 28, 2026 20:51 Inactive
@llastflowers

Copy link
Copy Markdown
Contributor Author

@llastflowers I have this one as well: #8332 hopefully these together will address some of the flakiness with VRT 😓

Oh amazing, I hope so too!! 🤞

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integration-tests: skipped manually Changes in this PR do not require an integration test skip changeset This change does not need a changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants