Stabilize ActionMenu dialog VRT - #8346
Conversation
|
There was a problem hiding this comment.
Copilot review overview
Review tier: Lite
Findings: None
What changed in this PR
This PR stabilizes the ActionMenu “Within Dialog” visual regression test by injecting a targeted CSS override during screenshot capture to hide a flaky, dynamically mounted button label, while keeping the rest of the UI (button/container/menu) comparable.
Changes:
- Adds a
toHaveScreenshotstyleoverride for theDev: Within DialogVRT variant to hide[data-component="text"]insideActionMenu.Button. - Keeps all other ActionMenu VRT variants unchanged by leaving the
styleoption unset for non-matching stories.
| File | Description |
|---|---|
e2e/components/ActionMenu.test.ts |
Injects story-specific screenshot CSS to avoid a one-pixel text-positioning flake in the “Within Dialog” VRT. |
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
|
@llastflowers I have this one as well: #8332 hopefully these together will address some of the flakiness with VRT 😓 |
Oh amazing, I hope so too!! 🤞 |
Changelog
Changed
Removed
None.
Rollout strategy
Testing & Reviewing