Skip to content

Remove redundant nil check for child_diff #4293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
preciz wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Remove redundant nil check for child_diff #4293

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/phoenix_live_view/diff.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -791,7 +791,7 @@ defmodule Phoenix.LiveView.Diff do
Map.put(new_prints, key, %{index: index, vars: new_vars, child_prints: child_prints})

# if the diff is empty, we need to check if the item moved
if child_diff == %{} or child_diff == nil do
if child_diff == %{} do
# check if the entry moved, then annotate it with the previous index
diff = if previous_index != index, do: Map.put(diff, index, previous_index), else: diff
{diff, index + 1, new_prints, pending, components, template}
Expand Down
Loading