Remove redundant nil check for child_diff#4293
Open
preciz wants to merge 1 commit into
Open
Conversation
child_diff is always a map.
Member
|
I don't think it is immediately obvious why it can't be nil, can you elaborate? |
Contributor
Author
|
Here traverse_dynamic is called with 6 arguments: phoenix_live_view/lib/phoenix_live_view/diff.ex Lines 780 to 788 in 8d2ecf2 Because of this phoenix_live_view/lib/phoenix_live_view/diff.ex Lines 640 to 642 in 8d2ecf2 And then it is never set to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
child_diff is always a map.