[Review view] SDTM Phase 2: Example datasets + adnca_example fixes#1329
Draft
Gero1999 wants to merge 1 commit into
Draft
[Review view] SDTM Phase 2: Example datasets + adnca_example fixes#1329Gero1999 wants to merge 1 commit into
Gero1999 wants to merge 1 commit into
Conversation
- Create pc_example, ex_example, dm_example datasets derived from adnca_example via data-raw/sdtm_example.R - Fix time-rounding issues in adnca_example that caused inconsistencies between SDTM and ADNCA paths - Extend metadata_nca_variables with SDTM, PC, EX, DM domain rows for the mapping UI - Add SDTM example dataset validation tests - Rename Tmax/Cmax to t_max/c_max in adnca_example.R (lint fix) Co-authored-by: Ona <no-reply@ona.com>
This was referenced May 27, 2026
Draft
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a review view into the SDTM changes from #1318. It isolates the example dataset changes for focused code review. The actual merge will happen via #1318.
Scope
New SDTM example datasets
pc_example— PC (concentrations) domain, one row per observation, derived fromadnca_exampleex_example— EX (dosing) domain, one row per dose eventdm_example— DM (demographics) domain, one row per subjectdata-raw/sdtm_example.Radnca_example fixes
Tmax/Cmaxparameters tot_max/c_max(lint compliance)adnca_example.rda,adnca_example.csv, andtest-multianalyte-ADNCA.csvMetadata extension
metadata_nca_variablesfor SDTM, PC, EX, DM domains with mapping sections and defaults for the Shiny mapping UIFiles changed
data-raw/adnca_example.R,data-raw/sdtm_example.Rdata/pc_example.rda,data/ex_example.rda,data/adnca_example.rda,data/metadata_nca_variables.rdadata/pc_example.csv,data/ex_example.csv,data/dm_example.csv,data-raw/adnca_example.csvdata-raw/metadata_nca_variables.csvtests/testthat/data/test-pc-example.csv,test-ex-example.csv,test-dm-example.csv,test-multianalyte-ADNCA.csvtests/testthat/test-sdtm_example_data.RWhat to review
data-raw/sdtm_example.R(PCDTC, PCRFTDTC, PCELTM, EXSTDTC, EXENDTC, EXDUR, EXELTM)adnca_exampletime-rounding changes — verify no existing tests breakmapping_section,sdtm_domain,Corevalues (DM usesPermnotExp)