[Review view] SDTM Phase 3: Shiny app integration#1330
Draft
Gero1999 wants to merge 1 commit into
Draft
Conversation
- Upload step: ADNCA/SDTM radio toggle, separate file inputs for PC (required), EX (required), subject-level (optional multi-file) - Mapping step: SDTM-specific panel with sections (SDTM General, PC Concentrations, EX Dosing, Supplemental Variables) - NCA pipeline: SDTM path calls sdtm_to_PKNCAdata() at mapping step - Export: SDTM mode exports PC/EX/DM as separate RDS files with dedicated script template applying column mapping - Settings: records input_mode and sdtm_metabolites - Default SDTM example data loaded when no files uploaded Co-authored-by: Ona <no-reply@ona.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a review view into the SDTM changes from #1318. It isolates the Shiny app integration for focused code review. The actual merge will happen via #1318.
Depends on Phase 1 (#1328) and Phase 2 (#1329).
Scope
Upload step (
data_upload.R)pc_example,ex_example,dm_example) loaded when no files uploaded.read_sdtm_domain(),.read_subject_level_files(),.build_sdtm_result()Mapping step (
data_mapping.R)sdtm_to avoid collisions with 6 shared ADNCA variable namesshinyjs::hidden()/toggle()(notconditionalPanel)sdtm_to_PKNCAdata()→ stores PKNCAdata → returns conc data for filtering.populate_adnca_inputs(),.populate_sdtm_inputs(),.get_adnca_metabolite_selection()NCA pipeline (
tab_data.R)pknca_datareactive branches on mode: SDTM retrieves PKNCAdata from mapping step; ADNCA uses existing pipelineExport (
zip-utils.R)script_template_sdtm.Rwith column mapping applied from session settingsSettings (
nca_setup.R,get_session_code.R)input_modeandsdtm_metabolitesget_settings_code()auto-selects template based oninput_modeFiles changed
inst/shiny/modules/tab_data/data_upload.Rinst/shiny/modules/tab_data/data_mapping.Rinst/shiny/modules/tab_data.Rinst/shiny/functions/zip-utils.Rinst/www/templates/script_template_sdtm.RR/get_session_code.Rinst/shiny/modules/tab_nca/nca_setup.R.lintrWhat to review
sdtm_prefix), column rename logicsdtm_raw→ mapping →sdtm_to_PKNCAdata()→ filtering → NCA