Skip to content

miniupnpd: use fw4 to indicate fw4 instead of nft #29964

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rohit-btuk wants to merge 1 commit into
base: master
Choose a base branch
from
+2 −2
Open

miniupnpd: use fw4 to indicate fw4 instead of nft #29964

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion net/miniupnpd/Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ include $(TOPDIR)/rules.mk

PKG_NAME:=miniupnpd
PKG_VERSION:=2.3.9
PKG_RELEASE:=3
PKG_RELEASE:=4

PKG_SOURCE_URL:=https://github.com/miniupnp/miniupnp/releases/download/miniupnpd_$(subst .,_,$(PKG_VERSION))
PKG_SOURCE:=$(PKG_NAME)-$(PKG_VERSION).tar.gz
Expand Down
2 changes: 1 addition & 1 deletion net/miniupnpd/files/miniupnpd.init
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ START=94
STOP=15
USE_PROCD=1
PROG=/usr/sbin/miniupnpd
[ -x "$(command -v nft)" ] && FW="fw4" || FW="fw3"
[ -x "$(command -v fw4)" ] && FW="fw4" || FW="fw3"

@openwrt-ai openwrt-ai Jul 10, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a functional change to how the firewall backend is selected (it alters runtime behavior on nftables-without-fw4 systems), not a cosmetic edit, so it should bump PKG_RELEASE so the updated init script is actually packaged and delivered to users. PKG_RELEASE is currently 3 and unchanged: net/miniupnpd/Makefile#L12. Please bump it to 4. (The openwrt bot's release audit flagged the same missing bump.)

Generated by Claude Code

@rohit-btuk rohit-btuk Jul 10, 2026 •
edited
Loading

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@openwrt-ai made the change.


upnpd_get_port_range() {
local var="$1"; shift
Expand Down