miniupnpd: use fw4 to indicate fw4 instead of nft#29964
Conversation
c3c4c5e to
1594e4b
Compare
openwrt-ai
left a comment
There was a problem hiding this comment.
Reviewed 1 new commit. The command -v nft → command -v fw4 change is correct: $FW is later invoked as an executable ($FW -q zone, fw4 reload), so gating on the actual fw4 binary rather than nft is the right condition. One inline comment on the missing PKG_RELEASE bump. Not a backport; commit message matches the change.
Generated by Claude Code
| USE_PROCD=1 | ||
| PROG=/usr/sbin/miniupnpd | ||
| [ -x "$(command -v nft)" ] && FW="fw4" || FW="fw3" | ||
| [ -x "$(command -v fw4)" ] && FW="fw4" || FW="fw3" |
There was a problem hiding this comment.
This is a functional change to how the firewall backend is selected (it alters runtime behavior on nftables-without-fw4 systems), not a cosmetic edit, so it should bump PKG_RELEASE so the updated init script is actually packaged and delivered to users. PKG_RELEASE is currently 3 and unchanged: net/miniupnpd/Makefile#L12. Please bump it to 4. (The openwrt bot's release audit flagged the same missing bump.)
Generated by Claude Code
Change miniupnpd init script to use "fw4" to indicate use of fw4, instead of "nft". This allows miniupnpd to work in a situation where the platform supports nftables, but not fw4. Signed-off-by: Rohit Pandey <rohit.pandey@bt.com>
1594e4b to
381a7c5
Compare
openwrt-ai
left a comment
There was a problem hiding this comment.
Reviewed 1 updated commit; no new issues found. The previously flagged missing PKG_RELEASE bump has been addressed (3 → 4), so the updated init script will be repackaged. The only substantive change since the last review is that release bump; the command -v nft → command -v fw4 init change was already confirmed correct.
Generated by Claude Code
Change miniupnpd init script to use "fw4" to indicate use of fw4, instead of "nft".
This allows miniupnpd to work in a situation where the platform supports nftables, but not fw4.
📦 Package Details
Maintainer: ardeleanalex@gmail.com
(You can find this by checking the history of the package
Makefile.)Description:
🧪 Run Testing Details
✅ Formalities
If your PR contains a patch:
git am(e.g., subject line, commit description, etc.)
We must try to upstream patches to reduce maintenance burden.