Skip to content

Fix Pitch Overwrite Mode #2326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stakira merged 1 commit into from
Aug 30, 2026
Merged

Fix Pitch Overwrite Mode #2326

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions OpenUtau/ViewModels/NotesViewModelHitTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -267,15 +267,18 @@ public PitchPointHitInfo HitTestPitchPoint(Point point) {
return null;
}
double tick = viewModel.PointToTick(point);
var phrase = viewModel.Part.renderPhrases.FirstOrDefault(p => p.end >= tick);
double absTick = tick + viewModel.Part.position;

var phrase = viewModel.Part.renderPhrases.FirstOrDefault(p => p.end >= absTick);
if (phrase == null) {
phrase = viewModel.Part.renderPhrases.Last();
}
if (phrase == null || phrase.pitchesBeforeDeviation.Length == 0) {
return null;
}
var curve = phrase.pitchesBeforeDeviation;
var pitchIndex = (int)Math.Round((tick - phrase.position + phrase.leading) / 5);
int phraseStartRel = phrase.position - viewModel.Part.position;
var pitchIndex = (int)Math.Round((tick - phraseStartRel + phrase.leading) / 5.0);
pitchIndex = Math.Clamp(pitchIndex, 0, curve.Length - 1);
return curve[pitchIndex];
}
Expand Down
Loading