Fix Pitch Overwrite Mode - #2326
Merged
stakira merged 1 commit intoAug 30, 2026
Merged
Conversation
maiko3tattun
added
dev-bug
emeraldsingers
added a commit
to emeraldsingers/UtauV
that referenced
this pull request
Aug 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug: SampleOverwritePitch mixed part-relative and absolute ticks, causing wrong pitch sampling when a part's position != 0.
Fix: convert the view tick to an absolute tick to select the correct RenderPhrase, and compute the phrase-relative index (phrase.position - part.position) when indexing pitchesBeforeDeviation.
Result: overwrite pitch sampling (DrawPitchState / SmoothenPitchState) returns the correct pitch regardless of part.position.