Skip to content

Fix unused functor parameter warnings breaking the CI #367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
balat wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix unused functor parameter warnings breaking the CI #367

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGES.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
# NEXT

* Fix the development-profile build with recent compilers: anonymize
unused functor parameters in printer and functor signatures
(warning 67)
* Fix typo `whitout` in type definition
(#324 by Martin @MBodin Bodin)
* Add support for the clip-path presentation attribute
Expand Down
2 changes: 1 addition & 1 deletion lib/html_f.mli
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ module Wrapped_functions
(** Similar to {!Make} but with a custom set of wrapped functions. *)
module Make_with_wrapped_functions
(Xml : Xml_sigs.T)
(C : Html_sigs.Wrapped_functions with module Xml = Xml)
(_ : Html_sigs.Wrapped_functions with module Xml = Xml)
(Svg : Svg_sigs.T with module Xml := Xml)
: Html_sigs.Make(Xml)(Svg).T
with type +'a elt = Xml.elt
Expand Down
2 changes: 1 addition & 1 deletion lib/svg_f.mli
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@ module Wrapped_functions
(** Similar to {!Make} but with a custom set of wrapped functions. *)
module Make_with_wrapped_functions
(Xml : Xml_sigs.T)
(C : Svg_sigs.Wrapped_functions with module Xml = Xml)
(_ : Svg_sigs.Wrapped_functions with module Xml = Xml)
: Svg_sigs.Make(Xml).T
with type +'a elt = Xml.elt
and type +'a attrib = Xml.attrib
6 changes: 3 additions & 3 deletions lib/xml_print.mli
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@ module type TagList = sig val emptytags : string list end
(** Printers for raw XML modules. *)
module Make_fmt
(Xml : Xml_sigs.Iterable)
(I : TagList)
(_ : TagList)
: Xml_sigs.Pp with type elt := Xml.elt

(** {2 Deprecated functors}
Expand All @@ -113,7 +113,7 @@ module Make_fmt

module Make
(Xml : Xml_sigs.Iterable)
(I : TagList)
(_ : TagList)
(O : Xml_sigs.Output)
: Xml_sigs.Printer with type out := O.out and type xml_elt := Xml.elt
[@@ocaml.deprecated "Use Xml_print.Make_fmt instead."]
Expand All @@ -129,7 +129,7 @@ module Make_typed

module Make_simple
(Xml : Xml_sigs.Iterable)
(I : TagList)
(_ : TagList)
: Xml_sigs.Simple_printer with type xml_elt := Xml.elt
[@@ocaml.deprecated "Use Xml_print.Make_fmt instead."]

Expand Down
Loading