Fix unused functor parameter warnings breaking the CI#367
Open
balat wants to merge 1 commit into
Open
Conversation
Recent compilers in the dune development profile treat warning 67 (unused functor parameter) as an error, which breaks make build and the CI on every platform. The parameters are only used for their side effects on behavior, not in the result signatures, so they can be anonymous.
This was referenced Jul 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The CI has been red on master since at least #364: recent compilers in the dune development profile treat warning 67 (unused functor parameter) as an error, which breaks
make buildon every platform (see for instance https://github.com/ocsigen/tyxml/actions/runs/29224082355).The affected parameters (
TagListin theXml_printfunctors,Wrapped_functionsinHtml_f/Svg_f.Make_with_wrapped_functions) only influence behavior, not the result signatures, so they can be anonymous in the interfaces.With this change,
dune build @installanddune runtestpass in the default profile on OCaml 5.4.Note: the
(ubuntu-latest, 4.08)job fails for an unrelated reason (the opam switch initialisation itself fails to solveocaml-base-compilerfor 4.08 with opam 2.5.2); this PR does not address that.