Skip to content

Remove Disqus identifier for comment migration #4478

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
leslieyip02 wants to merge 3 commits into
base: master
Choose a base branch
from
+5 −2
Draft

Remove Disqus identifier for comment migration #4478

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f831423
feat: remove disqus identifier for comment migration [build]
leslieyip02 Jul 23, 2026
494e8e7
cleanup: remove identifier field [build]
leslieyip02 Jul 23, 2026
a2e86cd
fix: add stable identifier [build]
leslieyip02 Jul 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion website/src/views/components/disqus/CommentCount.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,8 @@ vi.mock('utils/insertScript', () => ({ default: vi.fn() }));
(insertScript as MockedFunction<typeof insertScript>).mockResolvedValue(new Event('mock event'));

const disqusConfig = {
url: 'https://nusmods.com/courses/CS1010/reviews',
identifier: 'CS1010',
url: 'https://nusmods.com/courses/CS1010/reviews',
title: 'CS1010 Programming Methodology',
};

Expand Down
5 changes: 4 additions & 1 deletion website/src/views/modules/ModulePageContent.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,10 +57,13 @@ const ModulePageContent: React.FC<Props> = ({ module, archiveYear }) => {
const semesters = getSemestersOffered(module);
const isArchive = !!archiveYear;
const offered = isOffered(module);
const disqusIdentifier = Array.from(new Set([moduleCode, ...(module.aliases ?? [])]))
.sort()
.join('/');

const disqusConfig = {
identifier: disqusIdentifier,
url: `https://nusmods.com/courses/${moduleCode}/reviews`,
identifier: moduleCode,
title: pageTitle,
};

Expand Down