You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This PR removes the disqus_identifier field from the Disqus configuration to unblock URL-based comment migration. Without removing the identifier, Disqus's URL mapper cannot reassign comments from old module URLs to new ones.
Removes identifier from the DisqusConfig type and all call sites (ModulePageContent.tsx, CommentCount.tsx, DisqusComments.tsx, and the corresponding test).
After this change, Disqus thread identity is determined solely by page.url and data-disqus-url, which is the correct setup for URL-mapped migrations.
Confidence Score: 5/5
Safe to merge — the change is a consistent, targeted removal of a single field across all its usages, with no remaining references to identifier in the Disqus integration.
The removal is complete and consistent: the type definition, both Disqus components, the page-level config object, and the test are all updated. Disqus falls back to URL-only thread resolution when no identifier is provided, which is the intended behavior for the URL migration.
No files require special attention.
Sequence Diagram
sequenceDiagram
participant Page as ModulePageContent
participant DC as DisqusComments
participant CC as CommentCount
participant Disqus as Disqus API
Page->>DC: "disqusConfig { url, title }"
Page->>CC: "disqusConfig { url }"
DC->>Disqus: "configDisqus() — page.url, page.title (no identifier)"
CC->>Disqus: "span data-disqus-url only (no data-disqus-identifier)"
Disqus-->>Page: "Loads thread matched by URL only"
✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 58.92%. Comparing base (988c6fd) to head (a2e86cd). ⚠️ Report is 267 commits behind head on master.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Apparently,
disqus_identifierneeds to be removed in order for URL mapper comment migration to work.I have re-submitted the URL mapping:
DO NOT MERGE.
I'll be back in 24 hours.