Skip to content

fix: suppress compiler output and support external requires in extractRequiresInfoFromContent #1765

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Voctl wants to merge 2 commits into
base: master
Choose a base branch
from
+12 −6
Open

fix: suppress compiler output and support external requires in extractRequiresInfoFromContent #1765

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ef0ddbd
fix: suppress compiler output and add external requires in extractReq…
Voctl Jul 9, 2026
aeecc10
Merge branch 'master' into fix/extract-requires-silence
Voctl Jul 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 12 additions & 6 deletions src/nimblepkg/declarativeparser.nim
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -467,10 +467,11 @@ proc extractRequiresFromFile*(nimbleFileDir: string): seq[string] =

proc extractRequiresInfo*(nimbleFile: string, options: Options): NimbleFileInfo =
## Extract the `requires` information from a Nimble file. This does **not**
## evaluate the Nimble file. Errors are produced on stderr/stdout and are
## formatted as the Nim compiler does it. The parser uses the Nim compiler
## as an API. The result can be empty, this is not an error, only parsing
## errors are reported.
## evaluate the Nimble file. Parse issues are recorded in the returned
## NimbleFileInfo; they are NOT written to stderr/stdout so that errors in
## unrelated cached packages do not leak into the output of the current
## command (see https://github.com/nim-lang/nimble/issues/1717).
## The parser uses the Nim compiler as an API.
result.nimbleFile = nimbleFile
if isNimbleFileNim(nimbleFile):
let nimVersion = extractNimVersion(nimbleFile)
Expand All @@ -481,10 +482,13 @@ proc extractRequiresInfo*(nimbleFile: string, options: Options): NimbleFileInfo
conf.notes = {}
conf.mainPackageNotes = {}
conf.errorMax = high(int)
# Instead of calling localError (which writes to stderr via the Nim
# compiler message system), we just increment the error counter so that
# nfiParseError is set correctly — without leaking any terminal output.
conf.structuredErrorHook = proc(
config: ConfigRef, info: TLineInfo, msg: string, severity: Severity
) {.gcsafe.} =
localError(config, info, warnUser, msg)
inc config.errorCounter

let fileIdx = fileInfoIdx(conf, AbsoluteFile nimbleFile)
var parser: Parser
Expand All @@ -504,15 +508,17 @@ proc extractRequiresInfoFromContent*(content: string, options: Options): NimbleF
## Extract requires information from nimble file content (as a string).
## This is useful for parsing content obtained via `git show` without
## needing to write to a temp file.
## Parse errors are silenced (see extractRequiresInfo for rationale).
var conf = newConfigRef()
conf.foreignPackageNotes = {}
conf.notes = {}
conf.mainPackageNotes = {}
conf.errorMax = high(int)
# Same suppression as extractRequiresInfo: increment counter only.
conf.structuredErrorHook = proc(
config: ConfigRef, info: TLineInfo, msg: string, severity: Severity
) {.gcsafe.} =
localError(config, info, warnUser, msg)
inc config.errorCounter

# Create a dummy file index for the parser (it needs one for error reporting)
let fileIdx = fileInfoIdx(conf, AbsoluteFile "memory.nimble")
Expand Down
Loading