fix: suppress compiler output and support external requires in extractRequiresInfoFromContent - #1765
Open
Voctl wants to merge 2 commits into
Open
fix: suppress compiler output and support external requires in extractRequiresInfoFromContent#1765Voctl wants to merge 2 commits into
Voctl wants to merge 2 commits into
Conversation
Contributor
Author
|
Why There is no one |
Collaborator
|
Issue was fixed via d87747e |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses inconsistent error handling and missing features in
extractRequiresInfoFromContentcompared toextractRequiresInfo.Changes:
conf.structuredErrorHookinsideextractRequiresInfoFromContentto increment the error counter without leaking raw compiler/parser error messages tostderr. This ensures parse errors are properly silenced when extracting information from content (e.g., viagit show).extractRequiresFromFile(nimbleDir)and append them directly toresult.requires.How Has This Been Tested?
Related Issue
Closes #1717
P.S. This is my second PR here. I'm really excited about the Nim ecosystem and look forward to contributing more regularly. Even though I'm just 15, I've been spending my nights diving deep into Nim's repositories because I'm genuinely fascinated by the language and its design. I'm highly motivated to keep learning from this codebase and helping the project grow!