Skip to content

fix(files): proper accessible row name and title for overflow #61658

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
susnux wants to merge 1 commit into
base: master
Choose a base branch
from
+4 −3
Open

fix(files): proper accessible row name and title for overflow #61658

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions apps/files/src/components/FileEntry/FileEntryName.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,7 @@ export default defineComponent({
return {
is: 'span',
params: {
title: t('files', 'This node is unavailable'),
title: this.source.displayname + ` (${t('files', 'unavailable')})`,

@skjnldsv skjnldsv Jun 30, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use string replace for rtl lang compatibility

Suggested change
title: this.source.displayname + ` (${t('files', 'unavailable')})`,
title: t('files', '{displayName} (unavailable)', { displayName: this.source.displayname }),

},
}
}
Expand All @@ -148,11 +148,12 @@ export default defineComponent({
folder: this.activeFolder!,
contents: [],
})
const accessibleName = `${displayName}: ${this.source.displayname}`
return {
is: 'button',
params: {
'aria-label': displayName,
title: displayName,
'aria-label': accessibleName,
title: accessibleName,
tabindex: '0',
},
}
Expand Down
Loading