fix(files): proper accessible row name and title for overflow#61658
Open
susnux wants to merge 1 commit into
Open
fix(files): proper accessible row name and title for overflow#61658susnux wants to merge 1 commit into
susnux wants to merge 1 commit into
Conversation
CarlSchwan
reviewed
Jun 29, 2026
| is: 'span', | ||
| params: { | ||
| title: t('files', 'This node is unavailable'), | ||
| title: this.source.displayname + `(${t('files', 'unavailable')})`, |
Member
There was a problem hiding this comment.
this looks like a word puzzle
- resolves #59203 - resolves #56611 In the files list before this the accessible name of the button (default action) was overridden to the default action display name. But this causes problem for screen readers because then the whole table row is just called "view" or "download" instead of using the inner text (e.g. "filename.txt"). This fixes it to rename it `ACTION: FILENAME` instead. Also when long names were truncated there were no useful title (tooltip) for it, so it was not possible to get the real name. This is fixed by always provide a proper tooltip including the full name. Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
susnux
force-pushed
the
fix/files-node-name
branch
from
d7a3717 to
2bd8ec1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
In the files list before this the accessible name of the button (default action) was overridden to the default action display name. But this causes problem for screen readers because then the whole table row is just called "view" or "download" instead of using the inner text (e.g. "filename.txt").
This fixes it to rename it
ACTION: FILENAMEinstead.Also when long names were truncated there were no useful title (tooltip) for it, so it was not possible to get the real name. This is fixed by always provide a proper tooltip including the full name.
Checklist
3. to review, feature component)stable32)AI (if applicable)