Skip to content
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
71 commits
Select commit Hold shift + click to select a range
999bd7d
Added menu item
daniele-verducci Oct 6, 2026
710dbf7
Item detail layout and resources
daniele-verducci Oct 6, 2026
35fd5dc
Stubbed activities fragment, implemented ItemDetailsActivity with pag…
daniele-verducci Oct 6, 2026
5fade3b
Replaced menu items
daniele-verducci Oct 6, 2026
87b8672
Manifest
daniele-verducci Oct 6, 2026
0062b25
wip
daniele-verducci Oct 6, 2026
2565e43
Converted NoteShareActivity.java to Kotlin (automated conversion, no …
daniele-verducci Oct 12, 2026
fe161c5
Refactored NoteShareActivity to be more kotlin idiomatic
daniele-verducci Oct 12, 2026
47800e9
Converted NoteShareActivity to fragment
daniele-verducci Oct 12, 2026
53083fd
Removed stale code
daniele-verducci Oct 12, 2026
160c388
Cleanup: the searchable <meta-data> wasn't present in the activity de…
daniele-verducci Oct 12, 2026
a52556b
WIP passing required parameters
daniele-verducci Oct 12, 2026
5b704f7
Wired new details screen in place of old share, preserved system shar…
daniele-verducci Oct 13, 2026
4069d72
Moved collectNoteContents to worker thread to fix lint error (already…
daniele-verducci Oct 13, 2026
873be8f
Fixed view name
daniele-verducci Oct 13, 2026
910a6a0
Header content, tabs icons, theming
daniele-verducci Oct 13, 2026
78435b9
Actionbar
daniele-verducci Oct 13, 2026
f6be2fd
Removed size (we don't have such info right now)
daniele-verducci Oct 13, 2026
35f8618
Stubbed activities API and repository
daniele-verducci Oct 13, 2026
19b7c4d
Missing copyright headers
daniele-verducci Oct 14, 2026
9543b2b
Activities list layout
daniele-verducci Oct 14, 2026
3b27648
Implemented activities APIs
daniele-verducci Oct 14, 2026
2f16fbd
Implemented pagination for activities API
daniele-verducci Oct 14, 2026
81b5005
Implemented activities list, fix activity optional fields
daniele-verducci Oct 14, 2026
72443ae
Fix
daniele-verducci Oct 14, 2026
2ae3fb4
Empty list
daniele-verducci Oct 14, 2026
18f8a5f
Pull-to-refresh
daniele-verducci Oct 14, 2026
9265277
List incremental loading
daniele-verducci Oct 14, 2026
19e3633
WIP icons in activities list
daniele-verducci Oct 14, 2026
ed94a95
Prevent Glide to rewrite the url and point to the WebDAV storage for …
daniele-verducci Oct 15, 2026
70c2403
Converted CustomAppGlideModule to kotlin
daniele-verducci Oct 15, 2026
fd0c6ef
More kotlin-idiomatic CustomAppGlideModule
daniele-verducci Oct 15, 2026
b3a227d
Added SVG transcoder to CustomAppGlideModule (note: added dependency …
daniele-verducci Oct 15, 2026
49e9647
Added missing SvgDecoder (from Files app)
daniele-verducci Oct 15, 2026
6883e0c
Fixed Glide module not loaded since it was converted to Kotlin few co…
daniele-verducci Oct 15, 2026
4199fc2
gradlew --write-verification-metadata
daniele-verducci Oct 15, 2026
add0992
Implemented Versions API (note: added dependency jackrabbit-webdav, a…
daniele-verducci Oct 16, 2026
e33fc44
Implemented Versions repo
daniele-verducci Oct 16, 2026
a65cb29
Fixed Versions call failing because unauthenticated
daniele-verducci Oct 16, 2026
06885ec
Implemented Activity/Versions ordered merging and updated adapter to …
daniele-verducci Oct 19, 2026
3cfa40b
Fixed activity pagination (fileVersion endpoint donesn't have paginat…
daniele-verducci Oct 19, 2026
b8abecf
Applied branding color
daniele-verducci Oct 19, 2026
147de0a
List loading/refresh
daniele-verducci Oct 19, 2026
252a1e8
Restore version action icon
daniele-verducci Oct 19, 2026
0599f36
Implemented version restore, but MOVE Dav method is blocked by SSO li…
daniele-verducci Oct 19, 2026
aed40e1
Updated MOVE WebDAV request call to SSO lib, user-readable error in c…
daniele-verducci Oct 20, 2026
bf9afd7
Refactored entire data fetch and presentation
daniele-verducci Oct 20, 2026
27aaff3
Fixes
daniele-verducci Oct 20, 2026
0c3d272
Same order as web version, fixed pagination
daniele-verducci Oct 21, 2026
00ecb90
Unnecessary lateinit
daniele-verducci Oct 21, 2026
f00dc25
Edge case fix + restored missing error message
daniele-verducci Oct 22, 2026
29ff650
Prevent empty calls to activities
daniele-verducci Oct 22, 2026
0580364
Fixed empty list on servers with no Activities app
daniele-verducci Oct 22, 2026
c75fadc
Dates in list
daniele-verducci Oct 22, 2026
be33d9b
Cleaner repo impl, fixed load loop
daniele-verducci Oct 22, 2026
3d2a469
Catch exception
daniele-verducci Oct 22, 2026
06c751c
Fix wrong page loaded
daniele-verducci Oct 22, 2026
82a47bd
Close req
daniele-verducci Oct 22, 2026
96394d3
3-dots button in list alighed to Files app
daniele-verducci Oct 23, 2026
9fa3b9d
Added empty bottom sheet
daniele-verducci Oct 23, 2026
d7e5d52
Init bottom sheet layout
daniele-verducci Oct 23, 2026
a9e193f
Moved file to its own package
daniele-verducci Oct 23, 2026
a721c38
Completed bottom sheet implementation
daniele-verducci Oct 23, 2026
e121f99
Branding, aligned info screen to Files'
daniele-verducci Oct 23, 2026
d667be3
Fix crash
daniele-verducci Oct 23, 2026
bc53bb3
Safer context
daniele-verducci Oct 23, 2026
f331bfb
Added missing headers
daniele-verducci Oct 23, 2026
7a0657d
Format file sizes
daniele-verducci Oct 23, 2026
b05b918
Fix
daniele-verducci Oct 23, 2026
e890e97
Hide info button when more than one element is selected
daniele-verducci Oct 23, 2026
3a7f4f3
Sync note after version restore and notify editor show updated note w…
daniele-verducci Oct 23, 2026
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion app/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
*/

apply plugin: 'com.android.application'
apply plugin: 'com.google.devtools.ksp'

android {
namespace = 'it.niedermann.owncloud.notes'
Expand Down Expand Up @@ -130,6 +131,7 @@ dependencies {
implementation ('commons-httpclient:commons-httpclient:3.1') {
exclude group: 'commons-logging', module: 'commons-logging'
}
implementation 'org.apache.jackrabbit:jackrabbit-webdav:2.13.5'

implementation("com.github.nextcloud:android-library:2.26.0") {
exclude group: 'org.ogce', module: 'xpp3'
Expand All @@ -155,7 +157,8 @@ dependencies {

// Glide
implementation "com.github.bumptech.glide:glide:$glideVersion"
annotationProcessor "com.github.bumptech.glide:compiler:$glideVersion"
ksp "com.github.bumptech.glide:ksp:$glideVersion"
implementation "com.caverock:androidsvg-aar:1.4"

// Android X
implementation 'androidx.appcompat:appcompat:1.8.0'
Expand Down
2 changes: 1 addition & 1 deletion app/src/main/AndroidManifest.xml
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@
</activity>

<activity
android:name=".share.NoteShareActivity" />
android:name=".itemdetails.ItemDetailsActivity" />

<activity
android:name=".share.NoteShareDetailActivity" />
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,123 @@
/*
* Nextcloud Notes - Android Client
*
* SPDX-FileCopyrightText: 2026 Daniele Verducci <daniele.verducci@nextcloud.com>
* SPDX-FileCopyrightText: 2026 Nextcloud GmbH and Nextcloud contributors
* SPDX-License-Identifier: AGPL-3.0-or-later
*/
package it.niedermann.owncloud.notes.activities

import android.content.Context
import android.util.Log
import androidx.lifecycle.LifecycleCoroutineScope
import com.nextcloud.android.sso.helper.SingleAccountHelper
import it.niedermann.owncloud.notes.activities.ActivitiesFragment.Companion.TAG
import it.niedermann.owncloud.notes.activities.adapter.ActivitiesData
import it.niedermann.owncloud.notes.activities.repository.ActivitiesRepository
import it.niedermann.owncloud.notes.activities.repository.ActivitiesResult
import it.niedermann.owncloud.notes.activities.repository.VersionsRepository
import it.niedermann.owncloud.notes.activities.repository.VersionsResult
import kotlinx.coroutines.Dispatchers
import kotlinx.coroutines.Job
import kotlinx.coroutines.async
import kotlinx.coroutines.launch
import kotlinx.coroutines.withContext

class ActivitiesDataProvider (
val context: Context,
val lifecycleScope: LifecycleCoroutineScope,
val noteId: Long,
val listener: OnPageFetchedListener
) {
val data = ActivitiesData()
private var job: Job? = null

private val ssoAccount = SingleAccountHelper.getCurrentSingleSignOnAccount(context)
private val activitiesRepo = ActivitiesRepository(context, ssoAccount)
private val versionsRepo = VersionsRepository(context, ssoAccount)

fun fetchFirstPage() {
job?.cancel()
job = lifecycleScope.launch {
val (activitiesResult, versionsResult) = withContext(Dispatchers.IO) {
val activities = async {
activitiesRepo.fetchActivities(noteId)
}
val versions = async {
versionsRepo.fetchVersions(noteId)
}
activities.await() to versions.await()
}

if (!parseActivitiesResult(activitiesResult)) return@launch

if (!parseVersionsResult(versionsResult)) return@launch

listener.onPageFetched()
}
}

fun fetchNextPage() {
if (job?.isActive == true) return

if (!data.activitiesMore) return

job = lifecycleScope.launch {
val activitiesResult = withContext(Dispatchers.IO) {
activitiesRepo.fetchActivities(noteId, data.activitiesLastGiven)
}

if (!parseActivitiesResult(activitiesResult)) return@launch

listener.onPageFetched()
}
}

private fun parseActivitiesResult(activitiesResult: ActivitiesResult): Boolean {
return when (activitiesResult) {
is ActivitiesResult.Success -> {
data.activitiesLastGiven = activitiesResult.lastGiven
data.activitiesMore = activitiesResult.lastGiven != null
data.activities.addAll(activitiesResult.activities)
true
}

is ActivitiesResult.FailedNoCapability -> {
Log.d(TAG, "Server has no Activity endpoint")
data.activitiesMore = false
true
}

is ActivitiesResult.Failed -> {
Log.e(TAG, "Fetching activities failed")
listener.onPageFetchError()
false
}
}
}

private fun parseVersionsResult(versionsResult: VersionsResult): Boolean {
return when (versionsResult) {
is VersionsResult.Success -> {
data.versions.addAll(versionsResult.versions)
true
}
is VersionsResult.Failed -> {
Log.e(TAG, "Fetching versions failed")
false
}
}
}

fun reset() {
data.activities.clear()
data.versions.clear()
data.activitiesLastGiven = null
data.activitiesMore = true
}

interface OnPageFetchedListener {
fun onPageFetched()
fun onPageFetchError()
}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,180 @@
package it.niedermann.owncloud.notes.activities

import android.annotation.SuppressLint
import android.os.Bundle
import android.util.Log
import android.view.LayoutInflater
import android.view.View
import android.view.ViewGroup
import androidx.annotation.StringRes
import androidx.lifecycle.lifecycleScope
import com.google.android.material.snackbar.Snackbar
import com.nextcloud.android.sso.helper.SingleAccountHelper
import com.owncloud.android.lib.resources.files.model.FileVersion
import it.niedermann.owncloud.notes.R
import it.niedermann.owncloud.notes.activities.adapter.ActivityListAdapter
import it.niedermann.owncloud.notes.activities.adapter.OnActivityClickListener
import it.niedermann.owncloud.notes.activities.model.Activity
import it.niedermann.owncloud.notes.activities.repository.ActivitiesRepository
import it.niedermann.owncloud.notes.activities.repository.RestoreVersionsResult
import it.niedermann.owncloud.notes.activities.repository.VersionsRepository
import it.niedermann.owncloud.notes.branding.BrandedFragment
import it.niedermann.owncloud.notes.branding.BrandedSnackbar
import it.niedermann.owncloud.notes.branding.BrandingUtil
import it.niedermann.owncloud.notes.databinding.FragmentActivitiesBinding
import it.niedermann.owncloud.notes.persistence.NotesRepository
import it.niedermann.owncloud.notes.persistence.entity.Account
import it.niedermann.owncloud.notes.persistence.entity.Note
import it.niedermann.owncloud.notes.shared.util.extensions.getSerializableArgument
import kotlinx.coroutines.Dispatchers
import kotlinx.coroutines.launch
import kotlinx.coroutines.withContext

/*
* Nextcloud Notes - Android Client
*
* SPDX-FileCopyrightText: 2026 Daniele Verducci <daniele.verducci@nextcloud.com>
* SPDX-FileCopyrightText: 2026 Nextcloud GmbH and Nextcloud contributors
* SPDX-License-Identifier: AGPL-3.0-or-later
*/
class ActivitiesFragment : BrandedFragment(), OnActivityClickListener, ActivitiesDataProvider.OnPageFetchedListener {

lateinit var binding : FragmentActivitiesBinding
private lateinit var note: Note
private lateinit var account: Account
private lateinit var adapter: ActivityListAdapter

private lateinit var activityDataProvider: ActivitiesDataProvider

override fun onCreateView(inflater: LayoutInflater, container: ViewGroup?, savedInstanceState: Bundle?): View {
adapter = ActivityListAdapter(requireContext(), this)
binding = FragmentActivitiesBinding.inflate(inflater, container, false)

initializeArguments()
initializeList()

return binding.root
}

private fun initializeArguments() {
val bundler = arguments
note = bundler.getSerializableArgument(ARG_NOTE, Note::class.java)
?: throw IllegalArgumentException("Argument $ARG_NOTE is mandatory")
account = bundler.getSerializableArgument(ARG_ACCOUNT, Account::class.java)
?: throw IllegalArgumentException("Argument $ARG_ACCOUNT is mandatory")
}

private fun initializeList() {
val id = note.remoteId
if (id == null) {
Log.e(TAG, "Unable to load list: note has no remoteId")
return
}

activityDataProvider = ActivitiesDataProvider(
requireContext(),
lifecycleScope,
id,
this
)
binding.list.adapter = adapter
binding.swipeContainingList.setOnRefreshListener {
// Reload list
activityDataProvider.reset()
activityDataProvider.fetchFirstPage()
}

activityDataProvider.fetchFirstPage()
}

override fun applyBrand(color: Int) {
adapter.applyBrand(color)
val util = BrandingUtil.of(color, requireContext())
util.platform.colorViewBackground(binding.getRoot())
util.androidx.themeSwipeRefreshLayout(binding.swipeContainingList)
}

override fun onActivityItemClick(activity: Activity) {
// No action
}

override fun onVersionItemClick(version: FileVersion) {
binding.swipeContainingList.isRefreshing = true
// Restore the version
val ssoAccount =
SingleAccountHelper.getCurrentSingleSignOnAccount(requireContext())
val repository = VersionsRepository(requireContext(), ssoAccount)
lifecycleScope.launch(Dispatchers.IO) {
val result = repository.restoreVersion(version)
withContext(Dispatchers.Main) {
when (result) {
RestoreVersionsResult.Success -> syncNote()
RestoreVersionsResult.FailedUnsupported -> showMessage(R.string.version_restore_failed_unsupported)
else -> showMessage(R.string.version_restore_failed)
}
}
}
}

private fun syncNote() {
// Sync the restored note
val noteRepo = NotesRepository.getInstance(binding.root.context)
noteRepo.addCallbackPull(account, {
// Used in node editor: RESULT_OK means reload the note
requireActivity().setResult(android.app.Activity.RESULT_OK)

// Reload list
activityDataProvider.reset()
activityDataProvider.fetchFirstPage()

// Notify user
showMessage(R.string.version_restored)
})
noteRepo.scheduleSync(account, false)
}

private fun showMessage(@StringRes message: Int) {
BrandedSnackbar.make(binding.root, message, Snackbar.LENGTH_LONG).show()
}

override fun lastActivityReached() {
if (adapter.itemCount < ActivitiesRepository.PAGE_SIZE)
return
activityDataProvider.fetchNextPage()
}

@SuppressLint("NotifyDataSetChanged")
override fun onPageFetched() {
binding.swipeContainingList.isRefreshing = false
binding.emptyList.visibility = View.GONE
adapter.items.clear()
adapter.items.addAll(
activityDataProvider.data.getAggregatedList(requireContext())
)
adapter.lastActivity = activityDataProvider.data.activities.lastOrNull()
adapter.notifyDataSetChanged()
}

override fun onPageFetchError() {
binding.swipeContainingList.isRefreshing = false
if (adapter.items.isEmpty()) binding.emptyList.visibility = View.VISIBLE
BrandedSnackbar.make(binding.root, R.string.activities_error, Snackbar.LENGTH_SHORT).show()
}

companion object {
val TAG = ActivitiesFragment::class.simpleName
const val ARG_NOTE = "NOTE"
const val ARG_ACCOUNT = "ACCOUNT"

fun newInstance(note: Note, account: Account) : ActivitiesFragment {
val f = ActivitiesFragment()

val bundle = Bundle()
bundle.putSerializable(ARG_NOTE, note)
bundle.putSerializable(ARG_ACCOUNT, account)

f.arguments = bundle
return f
}
}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,33 @@
/*
* Nextcloud Notes - Android Client
*
* SPDX-FileCopyrightText: 2026 Daniele Verducci <daniele.verducci@nextcloud.com>
* SPDX-FileCopyrightText: 2026 Nextcloud GmbH and Nextcloud contributors
* SPDX-License-Identifier: AGPL-3.0-or-later
*/
package it.niedermann.owncloud.notes.activities.adapter

import android.content.Context
import com.owncloud.android.lib.resources.files.model.FileVersion
import it.niedermann.owncloud.notes.activities.model.Activity

class ActivitiesData {
val activities = arrayListOf<Activity>()
val versions = arrayListOf<FileVersion>()
var activitiesLastGiven: Long? = null
var activitiesMore: Boolean = true

fun getAggregatedList(context: Context) : List<ActivityListItem> {
val items = arrayListOf<ActivityListItem>()
items.addAll(
activities.map { ActivityListItem(context, it) }
)
items.addAll(
versions.map { ActivityListItem(context, it) }
)
items.sortDescending()
return items
}

fun isEmpty() : Boolean = activities.isEmpty() && versions.isEmpty()
}
Loading
Loading