Skip to content

Implement activities (files versions) - #3377

Draft
daniele-verducci wants to merge 71 commits into
mainfrom
feat/versions-activities
Draft

daniele-verducci wants to merge 71 commits into
mainfrom
feat/versions-activities

Conversation

@daniele-verducci

@daniele-verducci daniele-verducci commented Oct 6, 2026 •

Copy link
Copy Markdown
Contributor

⚠️ Depends on nextcloud/android#17852
⚠️ Depends on nextcloud/Android-SingleSignOn#1096 , that depends on nextcloud/Android-SingleSignOn#1098

Before reviewing this it's needed to:

  • merge the 3 PRs above
  • release a new singleSignOn lib version
  • update the singleSignOnVersion in build.gradle with the new version

(...or build all the dependencies from the respective repositories and point to them)

What's this?

Android implementation of nextcloud/files-clients#132

  • Adds a bottom sheet (aligns behaviour & appearance with Files app)
  • Adds a detail screen containing activities and share (aligns behaviour & appearance with Files app)
  • Implements a versions & activities list, with version restore
  • Moves sharing to Detail screen (to align it with Files app)
  • Adds option to reach the detail screen from within the editor

🖼️ Screenshots

🏚️ Before 🏡 After
Screenshot_20261023_181602 image
image image
image image
(didn't exist) image
(didn't exist) image
image image
image image

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not needed
  • 🔙 Backport requests are created or not needed: /backport to stable-xx.x
  • 📅 Milestone is set
  • 🌸 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

🤖 AI (if applicable)

  • The content of this PR was partly or fully generated using AI

@codacy-production

codacy-production Bot commented Oct 6, 2026 •

Copy link
Copy Markdown

Not up to standards ⛔

🔴 Issues 4 high · 14 medium · 73 minor

Alerts:
⚠ 91 issues (≤ 0 issues of at least minor severity)

Results:
91 new issues

Category Results
Documentation 69 minor
ErrorProne 4 high
Performance 1 medium
CodeStyle 4 minor
Complexity 13 medium

View in Codacy

🟢 Metrics 241 complexity · 2 duplication

Metric Results
Complexity 241
Duplication 2

View in Codacy

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

@github-actions

github-actions Bot commented Oct 6, 2026

Copy link
Copy Markdown
Contributor

APK file: https://github.com/nextcloud/notes-android/actions/runs/37498486797/artifacts/11429388555
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
qrcode (please click on link to get QR code displayed)

@daniele-verducci
daniele-verducci force-pushed the feat/versions-activities branch from ffd85fa to 1500341 Compare October 12, 2026 12:19
@github-actions

Copy link
Copy Markdown
Contributor

APK file: https://github.com/nextcloud/notes-android/actions/runs/38248370615/artifacts/11747525636
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
qrcode (please click on link to get QR code displayed)

@daniele-verducci
daniele-verducci force-pushed the feat/versions-activities branch 2 times, most recently from aa6b6e3 to 83b2a52 Compare October 12, 2026 16:57
@github-actions

Copy link
Copy Markdown
Contributor

APK file: https://github.com/nextcloud/notes-android/actions/runs/38396893559/artifacts/11814684541
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
qrcode (please click on link to get QR code displayed)

@github-actions

Copy link
Copy Markdown
Contributor

APK file: https://github.com/nextcloud/notes-android/actions/runs/38561146362/artifacts/11893339202
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
qrcode (please click on link to get QR code displayed)

@github-actions

Copy link
Copy Markdown
Contributor

APK file: https://github.com/nextcloud/notes-android/actions/runs/38600254298/artifacts/11913732039
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
qrcode (please click on link to get QR code displayed)

@daniele-verducci
daniele-verducci force-pushed the feat/versions-activities branch from 93f0456 to 3b9a44e Compare October 19, 2026 13:51
@github-actions

Copy link
Copy Markdown
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

Signed-off-by: daniele-verducci <daniele.verducci@nextcloud.com>
Signed-off-by: daniele-verducci <daniele.verducci@nextcloud.com>
…er and fragments

Signed-off-by: daniele-verducci <daniele.verducci@nextcloud.com>
Signed-off-by: daniele-verducci <daniele.verducci@nextcloud.com>
Signed-off-by: daniele-verducci <daniele.verducci@nextcloud.com>
Signed-off-by: daniele-verducci <daniele.verducci@nextcloud.com>
…refactoring)

Signed-off-by: daniele-verducci <daniele.verducci@nextcloud.com>
Signed-off-by: daniele-verducci <daniele.verducci@nextcloud.com>
Signed-off-by: daniele-verducci <daniele.verducci@nextcloud.com>
Signed-off-by: daniele-verducci <daniele.verducci@nextcloud.com>
…claration in the manifest (removed in commit 409e130), so componentName is always null

Signed-off-by: daniele-verducci <daniele.verducci@nextcloud.com>
Signed-off-by: daniele-verducci <daniele.verducci@nextcloud.com>
…e for multiple selection

Signed-off-by: daniele-verducci <daniele.verducci@nextcloud.com>
… present on main branch)

Signed-off-by: daniele-verducci <daniele.verducci@nextcloud.com>
Signed-off-by: daniele-verducci <daniele.verducci@nextcloud.com>
Signed-off-by: daniele-verducci <daniele.verducci@nextcloud.com>
Signed-off-by: daniele-verducci <daniele.verducci@nextcloud.com>
Signed-off-by: daniele-verducci <daniele.verducci@nextcloud.com>
Signed-off-by: daniele-verducci <daniele.verducci@nextcloud.com>
Signed-off-by: daniele-verducci <daniele.verducci@nextcloud.com>
Signed-off-by: daniele-verducci <daniele.verducci@nextcloud.com>
Signed-off-by: daniele-verducci <daniele.verducci@nextcloud.com>
Signed-off-by: daniele-verducci <daniele.verducci@nextcloud.com>
Signed-off-by: daniele-verducci <daniele.verducci@nextcloud.com>
Signed-off-by: daniele-verducci <daniele.verducci@nextcloud.com>
Signed-off-by: daniele-verducci <daniele.verducci@nextcloud.com>
Signed-off-by: daniele-verducci <daniele.verducci@nextcloud.com>
Signed-off-by: daniele-verducci <daniele.verducci@nextcloud.com>
Signed-off-by: daniele-verducci <daniele.verducci@nextcloud.com>
Signed-off-by: daniele-verducci <daniele.verducci@nextcloud.com>
Signed-off-by: daniele-verducci <daniele.verducci@nextcloud.com>
Signed-off-by: daniele-verducci <daniele.verducci@nextcloud.com>
Signed-off-by: daniele-verducci <daniele.verducci@nextcloud.com>
Signed-off-by: daniele-verducci <daniele.verducci@nextcloud.com>
Signed-off-by: daniele-verducci <daniele.verducci@nextcloud.com>
Signed-off-by: daniele-verducci <daniele.verducci@nextcloud.com>
…hen restoring from editor

Signed-off-by: daniele-verducci <daniele.verducci@nextcloud.com>
@daniele-verducci

Copy link
Copy Markdown
Contributor Author

Hey @nimishavijay , can you please have a look to the screenshots and let me know what do you think about it? I basically tried to align them to the Files app while respecting the Notes app style, but I may have missed something (not a very good graphic eye here 😅)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant