Skip to content

refactor(gui/search): build as a proper QML module - #10360

Merged
mgallien merged 1 commit into
masterfrom
feature/noid/searchdialog-qml-module
Jul 17, 2026
Merged

refactor(gui/search): build as a proper QML module#10360
mgallien merged 1 commit into
masterfrom
feature/noid/searchdialog-qml-module

refactor(gui/search): build as a proper QML module

d5b617d
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis failed Jul 17, 2026 in 22m 51s

Quality Gate failed

Failed conditions
E Maintainability Rating on New Code (required ≥ A)
19 New Code Smells (required ≤ 0)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Annotations

Check warning on line 775 in src/gui/systray.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename this identifier to be shorter or equal to 31 characters. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ9lWBI1ZWQS3kSMqEai&open=AZ9lWBI1ZWQS3kSMqEai&pullRequest=10360

Check warning on line 949 in src/gui/systray.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Unmodified variable "localFile" of type "class QFileInfo" should be const-qualified. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ9lWBI1ZWQS3kSMqEam&open=AZ9lWBI1ZWQS3kSMqEam&pullRequest=10360

Check warning on line 396 in src/gui/systray.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Unmodified variable "userIndex" of type "int" should be const-qualified. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ9lWBI1ZWQS3kSMqEaa&open=AZ9lWBI1ZWQS3kSMqEaa&pullRequest=10360

Check warning on line 506 in src/gui/systray.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use the init-statement to declare "userModelIndex" inside the if statement. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ9lWBI1ZWQS3kSMqEab&open=AZ9lWBI1ZWQS3kSMqEab&pullRequest=10360

Check warning on line 748 in src/gui/systray.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Unmodified variable "dialogWindow" of type "class QQuickWindow *" should be const-qualified. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ9lWBI1ZWQS3kSMqEag&open=AZ9lWBI1ZWQS3kSMqEag&pullRequest=10360

Check warning on line 726 in src/gui/systray.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

This function should be declared "const". 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ9lWBI1ZWQS3kSMqEae&open=AZ9lWBI1ZWQS3kSMqEae&pullRequest=10360

Check warning on line 321 in src/gui/systray.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Unmodified variable "userIndex" of type "int" should be const-qualified. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ9lWBI1ZWQS3kSMqEaZ&open=AZ9lWBI1ZWQS3kSMqEaZ&pullRequest=10360

Check warning on line 717 in src/gui/systray.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Unmodified variable "dialogWindow" of type "class QQuickWindow *" should be const-qualified. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ9lWBI1ZWQS3kSMqEad&open=AZ9lWBI1ZWQS3kSMqEad&pullRequest=10360

Check warning on line 1512 in src/gui/systray.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use the init-statement to declare "geo" inside the if statement. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ9lWBI1ZWQS3kSMqEao&open=AZ9lWBI1ZWQS3kSMqEao&pullRequest=10360

Check warning on line 929 in src/gui/systray.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename this identifier to be shorter or equal to 31 characters. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ9lWBI1ZWQS3kSMqEaj&open=AZ9lWBI1ZWQS3kSMqEaj&pullRequest=10360

Check warning on line 697 in src/gui/systray.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

This function should be declared "const". 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ9lWBI1ZWQS3kSMqEac&open=AZ9lWBI1ZWQS3kSMqEac&pullRequest=10360

Check warning on line 757 in src/gui/systray.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename this identifier to be shorter or equal to 31 characters. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ9lWBI1ZWQS3kSMqEah&open=AZ9lWBI1ZWQS3kSMqEah&pullRequest=10360

Check warning on line 106 in src/gui/systray.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this empty namespace. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ9lWBI1ZWQS3kSMqEaW&open=AZ9lWBI1ZWQS3kSMqEaW&pullRequest=10360

Check warning on line 929 in src/gui/systray.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Unmodified variable "accountState" of type "class OCC::AccountState *" should be const-qualified. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ9lWBI1ZWQS3kSMqEal&open=AZ9lWBI1ZWQS3kSMqEal&pullRequest=10360

Check warning on line 1041 in src/gui/systray.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace with the version of "std::ranges::transform" that takes a range. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ9lWBI1ZWQS3kSMqEan&open=AZ9lWBI1ZWQS3kSMqEan&pullRequest=10360

Check warning on line 243 in src/gui/systray.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Unmodified variable "userIndex" of type "int" should be const-qualified. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ9lWBI1ZWQS3kSMqEaY&open=AZ9lWBI1ZWQS3kSMqEaY&pullRequest=10360

Check warning on line 929 in src/gui/systray.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

This function should be declared "const". 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ9lWBI1ZWQS3kSMqEak&open=AZ9lWBI1ZWQS3kSMqEak&pullRequest=10360

Check warning on line 202 in src/gui/systray.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Unmodified variable "position" of type "enum OCC::Systray::WindowPosition" should be const-qualified. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ9lWBI1ZWQS3kSMqEaX&open=AZ9lWBI1ZWQS3kSMqEaX&pullRequest=10360

Check warning on line 726 in src/gui/systray.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Unmodified variable "account" of type "class QSharedPointer<class OCC::Account>" should be const-qualified. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ9lWBI1ZWQS3kSMqEaf&open=AZ9lWBI1ZWQS3kSMqEaf&pullRequest=10360
View more details on SonarQubeCloud