refactor(gui/search): build as a proper QML module - #10360
Merged
Conversation
Member
Author
|
/backport to stable-34.0 please |
nilsding
force-pushed
the
feature/noid/searchdialog-qml-module
branch
3 times, most recently
from
July 15, 2026 08:56
d139163 to
b7c271b
Compare
mgallien
enabled auto-merge
July 17, 2026 07:19
the QML files need to be in the same subdirectory as the module as per https://doc.qt.io/qt-6/qt-add-qml-module.html#adding-sources-and-resources-to-the-module otherwise cmake is unhappy and fails in a similar way to https://qt-project.atlassian.net/browse/QTBUG-122702 with `Error: [...]build/src/gui/search/meta_types/qt6nextcloudguisearch_metatypes.json:: Failed to parse JSON: 5 illegal value` Signed-off-by: Jyrki Gadinger <nilsding@nilsding.org>
mgallien
force-pushed
the
feature/noid/searchdialog-qml-module
branch
from
July 17, 2026 07:19
b7c271b to
d5b617d
Compare
Contributor
|
Artifact containing the AppImage: nextcloud-appimage-pr-10360.zip Digest: To test this change/fix you can download the above artifact file, unzip it, and run it. Please make sure to quit your existing Nextcloud app and backup your data. |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Inspired by #9005, but with just one module at a time.
This change allows for immediate feedback during build if any QML file is broken, e.g. a missing closing brace will now fail the build with the following error message:
This should also resolve any issues we had in the past with the local QML cache being outdated but still used, as the QML scenes are precompiled at the build time instead of at the runtime.
The QML files need to be in the same subdirectory as the module as per https://doc.qt.io/qt-6/qt-add-qml-module.html#adding-sources-and-resources-to-the-module; otherwise the build fails with
Error: [...]build/src/gui/search/meta_types/qt6nextcloudguisearch_metatypes.json:: Failed to parse JSON: 5 illegal value, apparently due to some limitations with CMake (https://qt-project.atlassian.net/browse/QTBUG-122702)Checklist
AI (if applicable)