[stable-34.0] refactor(gui/search): build as a proper QML module - #10391
Merged
Conversation
the QML files need to be in the same subdirectory as the module as per https://doc.qt.io/qt-6/qt-add-qml-module.html#adding-sources-and-resources-to-the-module otherwise cmake is unhappy and fails in a similar way to https://qt-project.atlassian.net/browse/QTBUG-122702 with `Error: [...]build/src/gui/search/meta_types/qt6nextcloudguisearch_metatypes.json:: Failed to parse JSON: 5 illegal value` Signed-off-by: Jyrki Gadinger <nilsding@nilsding.org>
backportbot
Bot
requested review from
claucambra,
i2h3,
mgallien and
nilsding
as code owners
July 17, 2026 08:29
nilsding
approved these changes
Jul 17, 2026
nilsding
enabled auto-merge
July 17, 2026 08:29
Contributor
|
Artifact containing the AppImage: nextcloud-appimage-pr-10391.zip Digest: To test this change/fix you can download the above artifact file, unzip it, and run it. Please make sure to quit your existing Nextcloud app and backup your data. |
claucambra
approved these changes
Jul 17, 2026
claucambra
approved these changes
Jul 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of PR #10360