-
Notifications
You must be signed in to change notification settings - Fork 100
feat: add warning about Lambda compatibility mode deprecation #7075
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
eduardoboucas
wants to merge
5
commits into
main
Choose a base branch
from
feat/lambda-compat-deprecation
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
87 changes: 87 additions & 0 deletions
87
packages/build/src/log/messages/lambda_compat_deprecation.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,87 @@ | ||
| import path from 'path' | ||
|
|
||
| import type { FunctionResult } from '@netlify/zip-it-and-ship-it' | ||
| import semver from 'semver' | ||
|
|
||
| import type { PluginsOptions } from '../../plugins/node_version.js' | ||
| import { isRuntime } from '../../utils/runtime.js' | ||
| import { log, logArray, logWarningSubHeader, type Logs } from '../logger.js' | ||
|
|
||
| const LEGACY_NEXTJS_RUNTIME_RANGE = '4.x' | ||
|
|
||
| interface LegacyNextjsRuntime { | ||
| name: string | ||
| version: string | ||
| } | ||
|
|
||
| const detectLegacyNextjsRuntime = (pluginsOptions: PluginsOptions[] | undefined): LegacyNextjsRuntime | null => { | ||
| const runtime = pluginsOptions?.find(isRuntime) | ||
| const version: unknown = runtime?.pluginPackageJson?.version | ||
|
|
||
| if (runtime && typeof version === 'string' && semver.satisfies(version, LEGACY_NEXTJS_RUNTIME_RANGE)) { | ||
| return { name: runtime.packageName, version } | ||
| } | ||
|
|
||
| return null | ||
| } | ||
|
|
||
| interface LogLambdaCompatibilityDeprecationOptions { | ||
| logs: Logs | undefined | ||
| results: FunctionResult[] | ||
| functionsSrc: string | undefined | ||
| pluginsOptions: PluginsOptions[] | undefined | ||
| } | ||
|
|
||
| /** | ||
| * Warns about JavaScript/TypeScript functions still using Lambda compatibility | ||
| * mode (V1) after bundling. | ||
| */ | ||
| export const logLambdaCompatibilityDeprecation = ({ | ||
| logs, | ||
| results, | ||
| functionsSrc, | ||
| pluginsOptions, | ||
| }: LogLambdaCompatibilityDeprecationOptions): void => { | ||
| const v1JsFunctions = results.filter((result) => result.runtime === 'js' && result.runtimeAPIVersion !== 2) | ||
|
|
||
| if (v1JsFunctions.length === 0) { | ||
| return | ||
| } | ||
|
|
||
| const userFns: string[] = [] | ||
| const generatedFns: string[] = [] | ||
|
|
||
| for (const fn of v1JsFunctions) { | ||
| if (functionsSrc && fn.mainFile.startsWith(`${functionsSrc}${path.sep}`)) { | ||
| userFns.push(fn.name) | ||
| } else { | ||
| generatedFns.push(fn.name) | ||
| } | ||
| } | ||
|
|
||
| logWarningSubHeader( | ||
| logs, | ||
| 'Lambda compatibility mode is deprecated and will be removed on June 1, 2027. Refer to https://ntl.fyi/lambda-deprecate for details.', | ||
| ) | ||
|
|
||
| if (userFns.length > 0) { | ||
| log(logs, '\n These functions in your project use Lambda compatibility mode:') | ||
| logArray(logs, userFns) | ||
| log(logs, '\n Migrate them to the modern Netlify Functions API. Refer to https://ntl.fyi/functions-migrate.') | ||
| } | ||
|
|
||
| if (generatedFns.length > 0) { | ||
| log(logs, '\n These functions were generated by a framework adapter and use Lambda compatibility mode:') | ||
| logArray(logs, generatedFns) | ||
|
|
||
| const legacyNextjsRuntime = detectLegacyNextjsRuntime(pluginsOptions) | ||
| if (legacyNextjsRuntime) { | ||
| log( | ||
| logs, | ||
| `\n Your project is using ${legacyNextjsRuntime.name} v${legacyNextjsRuntime.version}. Upgrade to the latest Netlify Next.js Adapter to emit modern Netlify Functions. Refer to https://ntl.fyi/nextjs-adapter-upgrade for upgrade guidance.`, | ||
| ) | ||
| } else { | ||
| log(logs, '\n Update the framework adapter to a version that emits modern Netlify Functions.') | ||
| } | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file not shown.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file not shown.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.