Skip to content

feat: add warning about Lambda compatibility mode deprecation#7075

Open
eduardoboucas wants to merge 5 commits into
mainfrom
feat/lambda-compat-deprecation
Open

feat: add warning about Lambda compatibility mode deprecation#7075
eduardoboucas wants to merge 5 commits into
mainfrom
feat/lambda-compat-deprecation

Conversation

@eduardoboucas

Copy link
Copy Markdown
Member

No description provided.

@eduardoboucas eduardoboucas requested a review from a team as a code owner May 28, 2026 09:30
@coderabbitai

coderabbitai Bot commented May 28, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: ca960305-5a7b-4095-8819-20e70fc5d5e0

📥 Commits

Reviewing files that changed from the base of the PR and between 17422de and 8916983.

⛔ Files ignored due to path filters (4)
  • packages/build/tests/core/snapshots/tests.js.snap is excluded by !**/*.snap
  • packages/build/tests/functions/snapshots/tests.js.snap is excluded by !**/*.snap
  • packages/build/tests/install/snapshots/tests.js.snap is excluded by !**/*.snap
  • packages/build/tests/plugins/snapshots/tests.js.snap is excluded by !**/*.snap
📒 Files selected for processing (4)
  • packages/build/tests/core/snapshots/tests.js.md
  • packages/build/tests/functions/snapshots/tests.js.md
  • packages/build/tests/install/snapshots/tests.js.md
  • packages/build/tests/plugins/snapshots/tests.js.md
✅ Files skipped from review due to trivial changes (2)
  • packages/build/tests/functions/snapshots/tests.js.md
  • packages/build/tests/plugins/snapshots/tests.js.md

📝 Walkthrough

Summary by CodeRabbit

  • New Features

    • Build now logs deprecation warnings for functions using legacy Lambda compatibility mode during bundling.
    • Warnings provide targeted migration guidance and include adapter-specific upgrade advice when a legacy framework adapter is detected.
    • Bundling now considers plugin configuration so warnings and step behavior reflect installed plugin options.
  • Tests

    • Updated test snapshots to include the new deprecation warnings.

Walkthrough

Threads pluginsOptions from runBuild through runSteps, runStep, tFireStep, and fireCoreStep. Adds a new logLambdaCompatibilityDeprecation module that filters JS functions using Lambda compatibility mode, partitions them into user vs framework-generated by mainFile location, detects legacy Next.js adapter runtime versions via pluginsOptions, and logs bucket-specific migration guidance. The logger is invoked after functions are bundled in the functions core plugin. ESLint suppression added for the new module.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The pull request description is entirely empty. The template requires a summary with issue reference, motivation, and completion checklist items. Add a comprehensive PR description including the issue number, motivation for the change, confirmation that tests/docs were updated, and a cute animal picture as encouraged.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title 'feat: add warning about Lambda compatibility mode deprecation' is clear, specific, and directly summarizes the main change—adding deprecation warnings for Lambda compatibility mode.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/lambda-compat-deprecation

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions

Copy link
Copy Markdown
Contributor

This pull request adds or modifies JavaScript (.js, .cjs, .mjs) files.
Consider converting them to TypeScript.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@packages/build/src/steps/run_step.ts`:
- Line 370: The call chain drops pluginsOptions: when runStep invokes
fireStep/tFireStep it does not pass the pluginsOptions parameter, so downstream
legacy adapter detection receives undefined; update the runStep implementation
to forward the pluginsOptions argument through to fireStep (and to tFireStep
where applicable) by adding pluginsOptions to the call site(s) so the same named
option object flows into the tFireStep/fireStep functions.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: b068b9c0-40f4-4fa1-b7e0-96169c6a3ed3

📥 Commits

Reviewing files that changed from the base of the PR and between 42d439a and 85c43c9.

📒 Files selected for processing (7)
  • eslint_temporary_suppressions.js
  • packages/build/src/core/build.ts
  • packages/build/src/log/messages/lambda_compat_deprecation.ts
  • packages/build/src/plugins_core/functions/index.ts
  • packages/build/src/steps/core_step.ts
  • packages/build/src/steps/run_step.ts
  • packages/build/src/steps/run_steps.js

Comment thread packages/build/src/steps/run_step.ts
@coderabbitai

coderabbitai Bot commented May 28, 2026

Copy link
Copy Markdown
Contributor

Actionable comments posted: 0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant