feat: add warning about Lambda compatibility mode deprecation#7075
feat: add warning about Lambda compatibility mode deprecation#7075eduardoboucas wants to merge 5 commits into
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (4)
📒 Files selected for processing (4)
✅ Files skipped from review due to trivial changes (2)
📝 WalkthroughSummary by CodeRabbit
WalkthroughThreads pluginsOptions from runBuild through runSteps, runStep, tFireStep, and fireCoreStep. Adds a new logLambdaCompatibilityDeprecation module that filters JS functions using Lambda compatibility mode, partitions them into user vs framework-generated by mainFile location, detects legacy Next.js adapter runtime versions via pluginsOptions, and logs bucket-specific migration guidance. The logger is invoked after functions are bundled in the functions core plugin. ESLint suppression added for the new module. Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
This pull request adds or modifies JavaScript ( |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@packages/build/src/steps/run_step.ts`:
- Line 370: The call chain drops pluginsOptions: when runStep invokes
fireStep/tFireStep it does not pass the pluginsOptions parameter, so downstream
legacy adapter detection receives undefined; update the runStep implementation
to forward the pluginsOptions argument through to fireStep (and to tFireStep
where applicable) by adding pluginsOptions to the call site(s) so the same named
option object flows into the tFireStep/fireStep functions.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: b068b9c0-40f4-4fa1-b7e0-96169c6a3ed3
📒 Files selected for processing (7)
eslint_temporary_suppressions.jspackages/build/src/core/build.tspackages/build/src/log/messages/lambda_compat_deprecation.tspackages/build/src/plugins_core/functions/index.tspackages/build/src/steps/core_step.tspackages/build/src/steps/run_step.tspackages/build/src/steps/run_steps.js
|
Actionable comments posted: 0 |
No description provided.