ogma-core: Allow for inputs to be deeply nested fields in ROS 2 template. Refs #547. - #550
Open
ivanperez-keera wants to merge 2 commits into
Open
ogma-core: Allow for inputs to be deeply nested fields in ROS 2 template. Refs #547.#550ivanperez-keera wants to merge 2 commits into
ogma-core: Allow for inputs to be deeply nested fields in ROS 2 template. Refs #547.#550ivanperez-keera wants to merge 2 commits into
Conversation
ivanperez-keera
force-pushed
the
develop-ros-subfields
branch
3 times, most recently
from
August 25, 2026 01:50
df0e450 to
123f321
Compare
…bfields. Refs nasa#547. The default ROS 2 template does not handle random value generation correctly in the auto-generated test package when subfields are used. For example, if an input variable `input_signal` is supposed to denote a field `pose.pose.position.x` of an input message, the code generated in the tests includes the invalid variable declaration: ```C++ double input_signal_pose.pose.position.x = randomFloat(); ``` This commit modifies the default ROS 2 template so that the test node generated uses variable names that do not include the sub-field name, and thus do not result in code that does not compile if variables are populated from message sub-fields.
ivanperez-keera
force-pushed
the
develop-ros-subfields
branch
from
August 25, 2026 03:19
123f321 to
4124c4f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modify the default ROS 2 template so that the test node generated uses variable names that do not include the sub-field name and thus do not result in code that does not compile if variables are populated from message sub-fields, as prescribed in the solution proposed for #547.