fix: guard all .get(key, 0) patterns that can return None (7 files, 17 occurrences)

[23241a6749]

Problem

dict.get(key, default) only substitutes default when the key is absent. A key that exists with value None passes straight through, so .get("views", 0) returns None and operations crash with TypeError.

Fix

Replace all 17 occurrences of dict.get(key, 0) with dict.get(key) or 0 where the dict value can be None — same root cause and fix pattern as PR #796.

Files changed (8 files, +17/−17)

File	Occurrences	Context
lib/github.py	4	item.get("comments", 0) in reactions + comments arithmetic
briefing.py	5	f.get("engagement_score", 0) in max() / sum()
lib/youtube_yt.py	1	.get("views", 0) in list.sort(key=...)
lib/instagram.py	1	Same sort-key pattern
lib/tiktok.py	1	Same sort-key pattern
lib/hackernews.py	1	.get("points", 0) in list.sort(key=...)
lib/signals.py	2	.get("views", 0) in engagement floor comparison
store.py	2	store_sightings boundary: engagement_score and relevance_score

Verification

All tests pass: store, signals, briefing, youtube, tiktok, hackernews, instagram, cli, internals, render.

[greptile-apps]

Greptile Summary

This PR makes nullable engagement and score fields safer to read. The main changes are:

• Defaults explicit None values to zero in score and engagement calculations.
• Updates sorting and threshold checks across source adapters.
• Stores sighting scores without collapsing every falsy value to zero.
• Encodes URL path, query, and fragment components without quoting the hostname.

Confidence Score: 5/5

This looks safe to merge.

• No blocking issues found in the changed code.

Important Files Changed

Filename	Overview
skills/last30days/scripts/lib/http.py	Adds component-level URL quoting for request URLs.
skills/last30days/scripts/store.py	Defaults only missing score values to zero at the sighting boundary.
skills/last30days/scripts/briefing.py	Handles missing engagement scores in daily and weekly aggregates.
skills/last30days/scripts/lib/github.py	Handles missing GitHub comment counts in parsed issue data.
skills/last30days/scripts/lib/signals.py	Handles missing YouTube view counts in relevance and floor checks.
skills/last30days/scripts/lib/hackernews.py	Handles missing Hacker News point counts during enrichment ordering.
skills/last30days/scripts/lib/instagram.py	Handles missing Instagram view counts during result ordering.
skills/last30days/scripts/lib/tiktok.py	Handles missing TikTok view counts during result ordering.
skills/last30days/scripts/lib/youtube_yt.py	Handles missing YouTube view counts during result ordering.

_{Reviews (2): Last reviewed commit: "fix: guard all .get(key, 0) patterns tha..." | Re-trigger Greptile}