fix(http): sanitize non-ASCII in URL before urllib.request to prevent latin-1 encode crash (fixes #817)#821
Open
23241a6749 wants to merge 1 commit into
Open
Conversation
… latin-1 encode crash
Contributor
Greptile SummaryThis PR makes HTTP request URLs ASCII-safe before they reach
Confidence Score: 5/5This looks safe to merge.
Important Files Changed
Reviews (1): Last reviewed commit: "fix(http): sanitize non-ASCII in URL bef..." | Re-trigger Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #817
Problem
Non-Latin-script topics (Arabic, CJK, Cyrillic, etc.) cause TikTok and Instagram ScrapeCreators requests to crash with:
Fix
Added a
urllib.parse.quotepass on the URL string afterurlencodeconstruction inhttp.request(), using a safe set that preserves all valid URL structural characters. This guarantees the URL is always 100% ASCII-safe before being passed tourllib.request.Request.safe='/:@!$&\'()*+,;=-._~%?#[]=+'Testing
test_http_v3.py: 14/14 passedtest_grounding_v3.py: 28/28 passedtest_env_v3.py: 13/13 passed