Skip to content

fix(http): sanitize non-ASCII in URL before urllib.request to prevent latin-1 encode crash (fixes #817) #821

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
23241a6749 wants to merge 1 commit into from
Closed

fix(http): sanitize non-ASCII in URL before urllib.request to prevent latin-1 encode crash (fixes #817) #821

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion skills/last30days/scripts/lib/http.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
from contextvars import ContextVar, copy_context
from pathlib import Path
from typing import Any, Dict, Optional, Union
from urllib.parse import parse_qsl, urlencode, urlsplit, urlunsplit
from urllib.parse import parse_qsl, urlencode, urlsplit, urlunsplit, quote

from . import health
from . import log as _log
Expand Down Expand Up @@ -556,6 +556,9 @@ def request(
if filtered:
separator = "&" if ("?" in url) else "?"
url = f"{url}{separator}{urlencode(filtered)}"
# Encode any non-ASCII characters to prevent UnicodeEncodeError from
# http.client.HTTPConnection.putrequest (which uses latin-1 internally).
url = quote(url, safe='/:@!$&\'()*+,;=-._~%?#[]=+')

fixture_request = _fixture_request(method, url, json_data, raw)
fixture_redactions = _fixture_redactions(url, headers, json_data)
Expand Down
Loading