Repository navigation
Fix Windows check-build failure by broadening OSTYPE detection in test.sh - #295
Merged
Merged
Conversation
Copilot
AI
changed the title
[WIP] Fix failing GitHub Actions job check-build (windows-latest, 3.12)
Fix Windows Jul 14, 2026
check-build failure by broadening OSTYPE detection in test.sh
mjpost
reviewed
Jul 14, 2026
| # OS X ships python -> python2 by default, be explicit | ||
| PYTHON=python3 | ||
| CMD="$PYTHON -m sacrebleu" | ||
| fi |
Owner
There was a problem hiding this comment.
Ah, I see, the previous version didn't match "msys" and there is no default case.
Collaborator
|
@copilot The tests are still failing. Let's set the default CMD and PYTHON and override it only for "$OSTYPE" == "darwin"*: |
Contributor
Author
... Implemented in commit |
martinpopel
approved these changes
Jul 17, 2026
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
check-buildGitHub Actions job onwindows-latestwith Python 3.12 failed becausetest.shdid not initializeCMDon Windows Git Bash. The script matchedOSTYPEonly when exactlymsys, while runners report values likemsys_nt-*.Root cause
test.shused an exact match:[[ "$OSTYPE" == "msys" ]]CMDremains unset underset -u.Change
[[ "$OSTYPE" == "msys"* ]]PYTHON/CMDacross Git Bash variants.Patch excerpt