Repository navigation
Make corpus_score_args checks stricter - #294
Conversation
|
Good idea. Thank you. Can you please add tests (that check that "when you give refs as a sequence of strings, not a sequence of sequence of strings" you'll get this error). |
|
I added some tests and expanded the scope to include |
Add tests Add changelog entry
|
The tests on Windows with Python 3.12 fail with Does anyone (@mjpost, @ozancaglayan) know how to fix it? I don't have time for debugging it (and no Windows box for testing). Also, this failure seems to be unrelated to this PR. |
|
Sorry @martinpopel, just saw this. I don't have a way to test locally. We could add Windows machines to the Github testing. Thanks for merging. |
Windows machines are already covered by our GitHub action tests. That's the place where I see the Luckily, it seems this error is deterministic (within three tests done so far, all three failed in Windows with Python 3.12 with the same error), so I've prompted GitHub Copilot to fix this bug (I'm on vacation with a small screen and no energy for delving into Windows-specific bugs), so let's wait for the result. |
I did this to catch an easy error to make when you give refs as a sequence of strings, not a sequence of sequence of strings. If you give a sequence of strings, it still gets accepted but I think the scores get calculated wrong.