Skip to content

Fix heap buffer overflow in secnetperf TCP frame reassembly #6266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Gaurav Singh (gaurav2699) wants to merge 2 commits into
base: main
Choose a base branch
from
+24 −1
Open

Fix heap buffer overflow in secnetperf TCP frame reassembly #6266

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
91d8a8b
Fix heap buffer overflow in secnetperf TCP frame reassembly
gaurav2699 Aug 25, 2026
c65f183
resolved comments
gaurav2699 Sep 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions src/perf/lib/Tcp.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -859,6 +859,10 @@ bool TcpConnection::ProcessReceiveData(const uint8_t* Buffer, uint32_t BufferLen

auto Frame = (TcpFrame*)BufferedData;
Comment thread
gaurav2699 marked this conversation as resolved.
auto FrameLength = (uint32_t)sizeof(TcpFrame) + Frame->Length + CXPLAT_ENCRYPTION_OVERHEAD;
Comment thread
gaurav2699 marked this conversation as resolved.
Outdated
if (FrameLength > sizeof(BufferedData)) {
WriteOutput("Invalid frame length\n");
Comment thread
gaurav2699 marked this conversation as resolved.
Outdated
return false;
}
auto BytesNeeded = FrameLength - BufferedDataLength;
if (BufferLength < BytesNeeded) {
goto BufferData;
Expand Down Expand Up @@ -895,6 +899,10 @@ bool TcpConnection::ProcessReceiveData(const uint8_t* Buffer, uint32_t BufferLen

BufferData:

if (BufferedDataLength + BufferLength > sizeof(BufferedData)) {
Comment thread
gaurav2699 marked this conversation as resolved.
WriteOutput("Invalid frame length\n");
return false;
}
CxPlatCopyMemory(BufferedData+BufferedDataLength, Buffer, BufferLength);
BufferedDataLength += BufferLength;

Expand Down
Loading