Fix heap buffer overflow in secnetperf TCP frame reassembly - #6266
Open
Gaurav Singh (gaurav2699) wants to merge 2 commits into
Open
Fix heap buffer overflow in secnetperf TCP frame reassembly#6266Gaurav Singh (gaurav2699) wants to merge 2 commits into
Gaurav Singh (gaurav2699) wants to merge 2 commits into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6266 +/- ##
==========================================
- Coverage 85.94% 85.46% -0.48%
==========================================
Files 60 60
Lines 18986 18976 -10
==========================================
- Hits 16317 16218 -99
- Misses 2669 2758 +89 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Guillaume Hetier (guhetier)
previously approved these changes
Aug 27, 2026
Guillaume Hetier (guhetier)
left a comment
Collaborator
There was a problem hiding this comment.
Looks ok, but some easy improvements that would have made understanding this logic easier (if we ignore that this could be refactored with a helper to buffer data and handle size validation, abstracting the error prone logic away)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
TcpConnection::ProcessReceiveData()copied frames into the fixed 16 KBBufferedDatabuffer usinguint16_tFrame->Length(frame up to 65555 bytes)with no bounds check. A remote peer could overflow the heap-allocated
TcpConnectionobject.
fixes: https://microsoft.visualstudio.com/OS/_workitems/edit/63537643/
Testing
NA
Documentation
NA