Skip to content

[MOO-2320] : Biometric Authetication not working issue fix #531

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
saurabhchavan1711 wants to merge 3 commits into
base: main
Choose a base branch
from
Open

[MOO-2320] : Biometric Authetication not working issue fix #531

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
da9557e
fix: fixed the biometric authetication issue
saurabhchavan1711 Jul 2, 2026
c283e00
fix: changelog and package json updated
saurabhchavan1711 Jul 2, 2026
b48b82a
fix: version update reverted
saurabhchavan1711 Jul 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions packages/jsActions/mobile-resources-native/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,8 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),

## [Unreleased]

- We have fixed the biometric authentication issue where it was not working on Android and crashing on iOS.

## [12.1.0] Native Mobile Resources - 2026-6-10

- Updated react-native from version 0.83.4 to 0.84.1.
Expand Down
2 changes: 1 addition & 1 deletion packages/jsActions/mobile-resources-native/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "mobile-resources-native",
"moduleName": "Native Mobile Resources",
"version": "12.1.0",
"version": "12.1.1",

@YogendraShelke YogendraShelke Jul 3, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be reverted. Version updates are necessary for widgets only, not for JS actions.

@saurabhchavan1711 saurabhchavan1711 Jul 3, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

"license": "Apache-2.0",
"copyright": "© Mendix Technology BV 2022. All rights reserved.",
"repository": {
Expand Down
2 changes: 1 addition & 1 deletion packages/jsActions/mobile-resources-native/src/authentication/BiometricAuthentication.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ export async function BiometricAuthentication(reason?: string): Promise<boolean>
// BEGIN USER CODE
// Documentation https://github.com/sbaiahmed1/react-native-biometrics

return simplePrompt(reason ?? "")
return simplePrompt(reason ?? " ")

@YogendraShelke YogendraShelke Jul 3, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should work, but does it make sense to use a meaningful default reason instead of an empty string? Using a blank string seems more likely to cause issues if Android or iOS decides to make that field mandatory in the future. Otherwise, we could make reason a required parameter for the action itself.

.then(result => result.success)
.catch(() => false);

Expand Down
Loading