[MOO-2320] : Biometric Authetication not working issue fix#531
Open
saurabhchavan1711 wants to merge 3 commits into
Open
[MOO-2320] : Biometric Authetication not working issue fix#531saurabhchavan1711 wants to merge 3 commits into
saurabhchavan1711 wants to merge 3 commits into
Conversation
| // Documentation https://github.com/sbaiahmed1/react-native-biometrics | ||
|
|
||
| return simplePrompt(reason ?? "") | ||
| return simplePrompt(reason ?? " ") |
Contributor
There was a problem hiding this comment.
This should work, but does it make sense to use a meaningful default reason instead of an empty string? Using a blank string seems more likely to cause issues if Android or iOS decides to make that field mandatory in the future. Otherwise, we could make reason a required parameter for the action itself.
| "name": "mobile-resources-native", | ||
| "moduleName": "Native Mobile Resources", | ||
| "version": "12.1.0", | ||
| "version": "12.1.1", |
Contributor
There was a problem hiding this comment.
This should be reverted. Version updates are necessary for widgets only, not for JS actions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
[XX-000]: description)? ✅Feature specific
This PR contains
What is the purpose of this PR?
This PR fixes the issue of biometric authetication not working on android and crashing on IOS.