Repository navigation
Conversation
Changed Files
|
Service preshutdown must suppress automatic core recovery and avoid launching the Ctrl+C helper while Windows is shutting down. Pass the host-owned process activity reader through the manager, process backend, and instance builders. Publish Quiescing before cancelling the shared SCM shutdown token, while keeping Stop graceful. Pin utils U1 and cover replacement, recovery, shutdown, and cancellation ordering with regression tests. Refs libnyanpasu/clash-nyanpasu#6054
4o3F
force-pushed
the
fix/session-process-lifecycle
branch
from
November 1, 2026 09:17
8250238 to
1c531b4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Connects the process activity input from libnyanpasu/nyanpasu-utils#218 to managed core supervision, so the service's SCM Preshutdown pauses automatic core recovery and Windows stops kill the existing process tree without launching the Ctrl+C helper.
Stacks on #469. Depends on libnyanpasu/nyanpasu-utils#218. Refs libnyanpasu/clash-nyanpasu#6054.
Changes
nyanpasu-utilstoa3ec581(U1).CoreManagerBuilder,ProcessRuntimeBackendandInstanceBuilderinto each supervisor: initial and replacement instances, recovery and shutdown. With no activity supplied, behavior is unchanged.Quiescingbefore cancelling the shared shutdown token from fix(service): bound Windows preshutdown and preserve cancellation #469. A plainStopstays graceful.Verification
clippy -D warnings, rustdoc and formatting pass.Cargo.lockis unchanged.aws-lc-sysbuild script (no mingw), so the Windows code paths here have only been reviewed by hand.Windows acceptance
The process-tree and helper tests are not in the CI matrix, so run these manually on Windows:
cargo test -p nyanpasu-utils --no-default-features --features process --test process_kill --test process_helper_smoke --test process_supervisorQuiescinglaunches zero Ctrl+C helpers and kills the whole tree, andStopstays graceful.Follow-up
If #218 is squash-merged, re-pin
nyanpasu-utilsto the merged commit.