Repository navigation
Conversation
Changed Files
|
Pass the revocable session input directly to the local core manager so pending session end pauses automatic recovery and avoids spawning the Windows shutdown helper. Restore normal behavior after revocation. Preserve the session reader's source-closure contract. Refs #6054
4o3F
force-pushed
the
fix/session-core-lifecycle
branch
from
November 1, 2026 09:18
9f6e046 to
a535aa8
Compare
4o3F
force-pushed
the
fix/windows-session-end
branch
from
November 1, 2026 09:18
214439d to
dd3e91e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Passes the session-end intent from #6117 directly into the local core manager. While a session end is pending, the local core is not restarted automatically, and on Windows a stop kills the existing process tree without launching the
--nyanpasu-process-shutdownCtrl+C helper. Revoking the intent (a cancelled shutdown) restores normal supervision and graceful stops.Stacks on #6117. Depends on libnyanpasu/nyanpasu-runtime#470 (stacked on #469) and libnyanpasu/nyanpasu-utils#218. Refs #6054.
Changes
backend/nyanpasu-runtimeto8250238(R1, which pins utilsa3ec581).SessionEndSource/SessionEndingkeep their public bool API but are backed by one utilsProcessActivitySource, so the Windows hook's write and the supervisor's read are the same input, with no forwarding task. The reader still reports that its source was dropped.local_host::buildtakes the session reader explicitly and passes its process activity to the core manager.setup.rsprovides it from the composition root.Verification
revoking_session_restores_normal_supervisiondrives the real fake-core throughCoreControl. While pending, the first attempt stays the recorded process. After revocation, exactly two retries run. It failed with the activity wiring removed, and it passed 5 consecutive runs.lint:architecture-ledger,lint:backend-boundariesand the scripts tests.hwidtest and nyanpasu-platform's proxy-port test.Merge order
Merge after #218, #469 and #470. If any of them is squash-merged, re-pin the submodule to the merged commits first.