Repository navigation
Conversation
Changed Files
|
Keep Win32 session handling and shutdown acknowledgement in the neutral platform crate so the GUI only composes the adapter and its callback, and a future CLI frontend can reuse it. Supply the cleanup wait bound from setup while preserving the first confirmation's deadline. Refs #6054
4o3F
force-pushed
the
refactor/session-end-platform-adapter
branch
from
November 1, 2026 11:21
649be9e to
df54648
Compare
4o3F
changed the base branch from
fix/session-core-lifecycle
to
fix/windows-session-end
November 1, 2026 11:21
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Moves the Windows session-end adapter, which has no Tauri dependency, out of
backend/tauriintonyanpasu-platform. The GUI now only composes it, and a future CLI frontend can reuse it. Stacks on #6119. Refs #6054.Changes
backend/tauri/src/shutdown_hook.rsmoves tonyanpasu-platform/src/session_end/windows.rs: the hidden Win32 window and its 2 Windows tests.backend/tauri/src/utils/session_end.rsmoves tonyanpasu-platform/src/session_end/protocol.rs: the pure message decision,ShutdownCompletionand its 5 tests.backend/tauri.setup.rs. The first confirmation still fixes the deadline, and later confirmations keep it.Verification
session_endtests (5), clash-nyanpasu tests (184; the 5 moved tests now run in platform), clippy, rustfmt,lint:architecture-ledgerandlint:backend-boundaries.aws-lc-sys), so the window tests need Windows CI.CLI note (not implemented)
A future console frontend should treat
CTRL_C/CTRL_BREAKas a normal stop. It should treatCTRL_CLOSE/CTRL_LOGOFF/CTRL_SHUTDOWNas a confirmed session end and block in the handler until cleanup is done. A process that loads user32 stops receiving the logoff and shutdown console events, so a CLI also needs this hidden-window hook.