Skip to content

[MAINTENANCE] Resolve Codacy no-underscore-dangle issues #2162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sebastian-meyer merged 2 commits into from
Sep 25, 2026
+20 −0
Merged

[MAINTENANCE] Resolve Codacy no-underscore-dangle issues #2162

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9fd5175
[MAINTENANCE] Resolve Codacy no-underscore-dangle issues
stweil Sep 21, 2026
0cf0dfb
Merge branch 'main' into fix/codacy-no-underscore-dangle
sebastian-meyer Sep 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions Build/.eslintrc.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,19 @@ module.exports = {
"plugin:import/recommended",
"plugin:@typescript-eslint/recommended"
],
"ignorePatterns": [
// Generated/bundled files are not linted.
"Resources/Public/JavaScript/DlfMediaPlayer/DlfMediaVendor.js",
// Third-party libraries are not linted.
"Resources/Public/JavaScript/Embedded3dViewer/",
"Resources/Public/JavaScript/Gridstack/",
"Resources/Public/JavaScript/HtmlMidiPlayer/",
"Resources/Public/JavaScript/OpenLayers/",
"Resources/Public/JavaScript/Verovio/",
"Resources/Public/JavaScript/jQuery/",
"Resources/Public/JavaScript/jQueryUI/",
"Resources/Public/JavaScript/Toastify/"
],
"overrides": [
{
"env": {
Expand All @@ -34,6 +47,13 @@ module.exports = {
],
"rules": {
"compat/compat": "error",
// The no-underscore-dangle rule (enforced by Codacy) flags every
// property access with a leading or trailing underscore. jQuery UI
// plugins and several first-party components rely on jQuery UI's
// private-method convention (_method, _super, etc.), so the rule is
// disabled; the remaining private-member style is enforced by code
// review.
"no-underscore-dangle": "off",
// turn on errors for missing imports
"import/no-unresolved": "error",
},
Expand Down
Loading