[MAINTENANCE] Resolve Codacy no-underscore-dangle issues - #2162
Merged
sebastian-meyer merged 2 commits intoSep 25, 2026
Merged
Conversation
Codacy's ESLint8 no-underscore-dangle pattern reports 335 issues, all in vendored third-party libraries (OpenLayers, jQuery UI, pdfkit, shaka-player, gridstack, model-viewer, ...) and the webpack-generated DlfMediaVendor.js bundle. Renaming private members in vendored code is not an option, so stop linting those files and disable the rule for the rest of the codebase, where jQuery UI's private-method convention (_method, _super) is used by first-party components. Assisted-by: OpenCode / qwen3.8-27b (Alibaba Cloud) Signed-off-by: Stefan Weil <stweil@users.noreply.github.com>
sebastian-meyer
added
the
⟳ maintenance
sebastian-meyer
approved these changes
Sep 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Codacy's ESLint8 no-underscore-dangle pattern reports 335 issues, all in vendored third-party libraries (OpenLayers, jQuery UI, pdfkit, shaka-player, gridstack, model-viewer, ...) and the webpack-generated DlfMediaVendor.js bundle. Renaming private members in vendored code is not an option, so stop linting those files and disable the rule for the rest of the codebase, where jQuery UI's private-method convention (_method, _super) is used by first-party components.
Assisted-by: OpenCode / qwen3.8-27b (Alibaba Cloud)