feat(mac): add new configuration window 馃崕 - #16299
Conversation
User Test ResultsTest specification and instructions User tests are not required |
|
This pull request is from an external repo and will not automatically be built. The build must still be passed before it can be merged. Ask one of the team members to make a manual build of this PR. |
delete keyboard button and changed it to work with UUID instead of index
and did minor refactoring
no longer required because of changes to the way installed packages are removed
for whether or not a package's disclosure group is expanded
and style changes
f49dc2a to
2b2fc15
Compare
sgschantz
left a comment
sgschantz
left a comment
There was a problem hiding this comment.
This looks good! I have suggested some minor comment changes and would like to see you take care of the remaining TODOs. Also, would it be possible to confirm (or cancel) the Add Keyboard in the case of a downgrade?
| // a VStack is shown as the label for each disclosure group | ||
| VStack (alignment: .leading, spacing: 0) { | ||
| HStack { | ||
| // if the package contains one keyboard shows the keyboard name, otherwise show the package name |
There was a problem hiding this comment.
| // if the package contains one keyboard shows the keyboard name, otherwise show the package name | |
| // if the package contains one keyboard, show the keyboard name, otherwise show the package name |
|
|
||
| // settings.singleKeyboardPackages or settings.multiKeyboardPackages | ||
| let packages: [KeymanPackage] | ||
| // a boolean for weather or not a package contains multiple keyboards |
There was a problem hiding this comment.
| // a boolean for weather or not a package contains multiple keyboards | |
| // a boolean for whether or not a package contains multiple keyboards |
| * | ||
| * Created by Gabriel Schantz on 2026-07-27 | ||
| * | ||
| * View for a package row |
There was a problem hiding this comment.
Expand on this description a little to explain how this view varies depending on whether the package it represents contains a single or multiple keyboards
| * | ||
| * Created by Gabriel Schantz on 2026-08-03 | ||
| * | ||
| * Webview used to show help for Keyman keyboards |
There was a problem hiding this comment.
Technically this is the package help being displayed -- not that this view has any knowledge of that...
3 participants
The configuration window allows the user to manage Keyman packages and keyboards.
Actions include:
Build-bot: release:mac
Test-bot: skip