feat(mac): expand Keyman package data model 🍎 - #16247
Merged
Merged
Conversation
each array is sorted, one for multiple-keyboard packages and one for single-keyboard packages
User Test ResultsTest specification and instructions User tests are not required Test Artifacts |
unit test fix
Sendsend a distributed notification from the config app whenever a change to the enabled keyboards occurs. In response, the input method loads the list of enabled keyboards and updates the Keyman menu.
…p/keyman into feat/mac/expand-package
also explict call default() to be sure that we get back a DistributedNotificationCenter
…p/keyman into feat/mac/expand-package
sgschantz
marked this pull request as ready for review
July 29, 2026 20:02
darcywong00
reviewed
Jul 30, 2026
jahorton
reviewed
Jul 30, 2026
feat(mac): update input method on keyboard configuration change 🍎
jahorton
approved these changes
Aug 5, 2026
jahorton
left a comment
jahorton
left a comment
Contributor
There was a problem hiding this comment.
LGTM aside from one (probably important) point.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add necessary fields to KeymanPackage class so they will available for the configuration UI
Include a function for generating the QR Code to share a package
For easier presentation, publish the installed packages in two arrays: one for single keyboard packages and one for multiple keyboard packages
Note that all the UI implementation in this PR is for testing purposes only and will be replaced. The UI is being developed separately in #16304, #16252 and #16299.
Build-bot: release:mac
Test-bot: skip