Skip to content

[Enhancement] Add support for custom attribute removal - #422

Merged
ledsoft merged 19 commits into
kbss-cvut:developmentfrom
lukaskabc:lukaskabc/ui/820-delete-custom-attributes
Sep 4, 2026
Merged

ledsoft merged 19 commits into
kbss-cvut:developmentfrom
lukaskabc:lukaskabc/ui/820-delete-custom-attributes

Conversation

@lukaskabc

@lukaskabc lukaskabc commented Aug 27, 2026 •

Copy link
Copy Markdown
Collaborator

kbss-cvut/termit-ui#820

Frontend PR: kbss-cvut/termit-ui#848

This PR adds two REST endpoints for retrieving usages of a custom attribute and for removing a custom attribute, optionally with all its usages.

The PR also fixes missing authorization for custom attribute update.

@lukaskabc
lukaskabc requested a review from Haschman August 27, 2026 13:28
@lukaskabc lukaskabc added the enhancement New feature or request label Aug 27, 2026
@lukaskabc

Copy link
Copy Markdown
Collaborator Author

There was an issue where the backend would still return the attribute usages as additional properties, although the data was removed from the database.
For this reason, jopa's entity manager cache will evict cache for affected contexts.

@lukaskabc
lukaskabc requested a review from ledsoft August 31, 2026 05:45
@lukaskabc
lukaskabc marked this pull request as draft August 31, 2026 11:56
@lukaskabc
lukaskabc marked this pull request as ready for review September 2, 2026 08:39
@lukaskabc

Copy link
Copy Markdown
Collaborator Author

The option to keep usages of the custom attribute has been implemented as discussed in the meeting.
This is now ready for review @ledsoft

@lukaskabc
lukaskabc force-pushed the lukaskabc/ui/820-delete-custom-attributes branch 2 times, most recently from 458bafe to 82f03bf Compare September 3, 2026 11:38

@ledsoft ledsoft left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the inline comments.

@lukaskabc
lukaskabc force-pushed the lukaskabc/ui/820-delete-custom-attributes branch from 96ada45 to 60fa2b7 Compare September 4, 2026 07:52
@lukaskabc
lukaskabc requested a review from ledsoft September 4, 2026 07:55
…h removeUsages in remove custom attribute data repository method

@ledsoft ledsoft left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ledsoft
ledsoft merged commit c5278c4 into kbss-cvut:development Sep 4, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Delete custom attributes/smazání vlastních atributů

2 participants