Skip to content

[Enhancement #820] Add support for custom attribute removal - #848

Merged
ledsoft merged 13 commits into
kbss-cvut:developmentfrom
lukaskabc:lukaskabc/ui/820-delete-custom-attributes
Sep 4, 2026
Merged

ledsoft merged 13 commits into
kbss-cvut:developmentfrom
lukaskabc:lukaskabc/ui/820-delete-custom-attributes

Conversation

@lukaskabc

@lukaskabc lukaskabc commented Aug 27, 2026 •

Copy link
Copy Markdown
Collaborator

#820

Backend PR: kbss-cvut/termit#422

This PR adds remove buttons to the list of custom attributes, allowing them to be removed (administration > customization).

Before the attribute is removed, a confirmation modal is shown.
If the attribute is already used, its usage is listed, and the user must confirm the removal by entering the attribute name in the input field.
The user can choose to keep the attribute usages and remove only the attribute itself.

@lukaskabc lukaskabc added the enhancement New feature or request label Aug 27, 2026
@lukaskabc
lukaskabc requested a review from Haschman August 27, 2026 14:06
@lukaskabc
lukaskabc requested a review from ledsoft August 31, 2026 05:45
@lukaskabc
lukaskabc marked this pull request as draft August 31, 2026 11:56
@lukaskabc
lukaskabc marked this pull request as ready for review September 2, 2026 08:38

@ledsoft ledsoft left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have not tested yet, just code review feedback.

Comment thread src/action/AsyncCustomizationActions.ts Resolved
Comment thread src/action/AsyncCustomizationActions.ts Resolved
Comment thread src/action/AsyncCustomizationActions.ts Resolved
Comment thread src/action/SyncActions.ts Resolved
Comment thread src/component/misc/table/Pagination.tsx Resolved
Comment thread src/i18n/cs.ts Resolved
Comment thread src/i18n/cs.ts Resolved
Comment thread src/i18n/cs.ts Resolved
@lukaskabc
lukaskabc force-pushed the lukaskabc/ui/820-delete-custom-attributes branch from 217da70 to 26eaba1 Compare September 3, 2026 07:57
@lukaskabc
lukaskabc requested a review from ledsoft September 3, 2026 12:19

@ledsoft ledsoft left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ledsoft ledsoft linked an issue Sep 4, 2026 that may be closed by this pull request
@ledsoft
ledsoft force-pushed the lukaskabc/ui/820-delete-custom-attributes branch from 75c515b to 0da521b Compare September 4, 2026 08:19
@ledsoft
ledsoft merged commit 26de0ad into kbss-cvut:development Sep 4, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Delete custom attributes/smazání vlastních atributů

2 participants