Skip to content

fix: handle cascade delete when AccessAttemptExpiration table missing #1453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
muhamedfazalps wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: handle cascade delete when AccessAttemptExpiration table missing #1453

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 13 additions & 2 deletions axes/handlers/database.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -440,8 +440,19 @@ def reset_user_attempts(

count = 0
for attempts in attempts_list:
_count, _ = attempts.delete()
count += _count
try:
_count, _ = attempts.delete()
count += _count
except Exception:
# If the AccessAttemptExpiration table does not exist
# (migration not applied), cascade delete will fail.
# Log a warning and continue with remaining attempts.
log.warning(
"AXES: Failed to delete access attempt for %s. "
"This may happen if the AccessAttemptExpiration "
"migration has not been applied.",
attempts,
)
log.info("AXES: Reset %s access attempts from database.", count)

return count
Expand Down