fix: handle cascade delete when AccessAttemptExpiration table missing#1453
Open
muhamedfazalps wants to merge 1 commit into
Open
fix: handle cascade delete when AccessAttemptExpiration table missing#1453muhamedfazalps wants to merge 1 commit into
muhamedfazalps wants to merge 1 commit into
Conversation
reset_user_attempts() calls attempts.delete() which triggers cascade deletion of related AccessAttemptExpiration objects. When the AccessAttemptExpiration migration has not been applied, the table does not exist and the cascade delete raises an error. Fix: wrap delete in try/except, log a warning, and continue. Fixes jazzband#1389
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1389
Problem
Starting with django-axes 8.1.0, the AccessAttemptExpiration model was introduced. If an application does not apply the migration for this model, deleting AccessAttempt objects during a successful login triggers cascade deletion logic that attempts to delete a related AccessAttemptExpiration. Since the table does not exist, this results in an error.
Fix
Wrap the delete call in a try/except block. If the cascade delete fails (e.g., because the AccessAttemptExpiration table does not exist), log a warning and continue with remaining attempts instead of crashing.
Changes